ruff compliance for D405 and D407#5666
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5666 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22807 22807
Branches 5441 5441
=======================================
Hits 20456 20456
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
|
Ready for review. |
docs/src/developers_guide/documenting/docstrings_sample_routine.py
Outdated
Show resolved
Hide resolved
pp-mo
left a comment
There was a problem hiding this comment.
OK lost of small suggestions + comments.
Got as far down as the end of the lib/iris/analysis/stats.py listing.
I definitely went about this the wrong way.
I will finish the job with remaining suggestions on a PR-to-PR branch
docs/src/developers_guide/documenting/docstrings_sample_routine.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
too much overlap with existing discussions + agreed approach
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
* 'ruff11' of github.com:tkknight/iris: Update lib/iris/_concatenate.py
|
@pp-mo Thanks for wading in, but in this case it might have been better touching base with @tkknight (or myself) beforehand. You weren't to know that @tkknight and I agreed on a strategy over several offline discussion on how to proceed with the If you're a gun for hire, then let us know. You're more than welcome to join us help chip away at the mountain of outstanding work to do. Apologies if you lost time and effort on this. |
* main: ruff compliance for D106. (SciTools#5676) ruff complliance for rule D202. (SciTools#5674) nep29 drop numpy 1.22 (SciTools#5668) ruff compliance for D404. (SciTools#5671) ruff complliance for D406. (SciTools#5670) ruff compliance for D405 and D407 (SciTools#5666) Various ruff rule compliance (W, CPY, ISC, AIR) (SciTools#5667)
🚀 Pull Request
Description
PR solely for fixing:
D405: Section name should be properly capitalizedD407: Missing dashed underline after sectionWhilst fixing the docstrings for
D407I noticed it would use two different styles of headings in functions so I fixed all the headings in all files touched, so the PR is a little bigger than planned but the files touched have not grown.Continues work of #5625.
Consult Iris pull request check list