Merged
Conversation
* upstream/main: ruff complliance for D100. (SciTools#5678)
for more information, see https://pre-commit.ci
* 'ruff_D205_2' of github.com:tkknight/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5681 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22809 22809
Branches 5440 5440
=======================================
Hits 20458 20458
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
bjlittle
requested changes
Jan 11, 2024
Member
bjlittle
left a comment
bjlittle
left a comment
There was a problem hiding this comment.
@tkknight Gosh. This was hard.
You've make an incredible effort to reformat the docstrings.
I've tried my best to complement your efforts to formulate an appropriate single line summary for each docstring. We don't need perfection here, as we can iterate over time and massage the content.
A bunch of suggestions which you can accept or not.
Either way, a huge effort and a decent step forwards 💯 👍
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
* upstream/main: Removed use of catch_warnings (SciTools#5685)
Contributor
Author
|
All review comments accepted - one at a time until I reliased there was a batch option! One additional commit from my final read thru, minor layout and spotted some duplicate text. See d168d07. Think this is now ready. |
bjlittle
approved these changes
Jan 12, 2024
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jan 15, 2024
* upstream/main: ruff compliance for D205. (SciTools#5681) Added whatsnew to warnings PR (SciTools#5696) Removed use of catch_warnings (SciTools#5685) Better documentation for Cube names in curl (SciTools#5680) fix typo (SciTools#5689) Make further topics obviously different (SciTools#5684) [pre-commit.ci] pre-commit autoupdate (SciTools#5682)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jan 15, 2024
* upstream/main: ruff compliance for D205. (SciTools#5681) Added whatsnew to warnings PR (SciTools#5696) Removed use of catch_warnings (SciTools#5685) Better documentation for Cube names in curl (SciTools#5680) fix typo (SciTools#5689)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jan 15, 2024
* upstream/main: ruff compliance for D205. (SciTools#5681) Added whatsnew to warnings PR (SciTools#5696) Removed use of catch_warnings (SciTools#5685) Better documentation for Cube names in curl (SciTools#5680)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jan 24, 2024
* upstream/main: (26 commits) Bump scitools/workflows from 2023.12.1 to 2024.01.0 (SciTools#5710) Faster trivial equality checks for coordinates and arrays (SciTools#5691) Make the Coord.cell method lazy (SciTools#5693) Re-write `pearsonr` to use `Resolve` (SciTools#5638) ruff compliance for D401. (SciTools#5687) Bump actions/cache from 3 to 4 (SciTools#5703) update rtd ubuntu and mambaforge (SciTools#5702) [pre-commit.ci] pre-commit autoupdate (SciTools#5699) ruff compliance for D205. (SciTools#5681) Added whatsnew to warnings PR (SciTools#5696) Removed use of catch_warnings (SciTools#5685) Better documentation for Cube names in curl (SciTools#5680) fix typo (SciTools#5689) Make further topics obviously different (SciTools#5684) [pre-commit.ci] pre-commit autoupdate (SciTools#5682) ruff complliance for D100. (SciTools#5678) move tests.pp to tests.__init__ (SciTools#5679) ruff compliance for D417, D106 (SciTools#5677) ruff compliance for D200. (SciTools#5675) ruff compliance for D106. (SciTools#5676) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
PR solely for fixing
D205: 1 blank line required between summary line and descriptionContinues work of #5625.
Consult Iris pull request check list