Consider NaNs equal when comparing cubes#5713
Merged
trexfeathers merged 4 commits intoSciTools:mainfrom Feb 13, 2024
Merged
Conversation
bouweandela
force-pushed
the
cubes-nan-equal
branch
from
5c38c81 to
5e2a974
Compare
trexfeathers
added
the
benchmark_this
trexfeathers
requested changes
Feb 9, 2024
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks very much @bouweandela! Would you be happy with these adjustments?
Contributor
Performance Benchmark Report: 3b71f54Performance shiftsFull benchmark resultsGenerated by GHA run |
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5713 +/- ##
=======================================
Coverage 89.71% 89.71%
=======================================
Files 90 90
Lines 22816 22817 +1
Branches 5438 5439 +1
=======================================
+ Hits 20469 20470 +1
Misses 1617 1617
Partials 730 730 ☔ View full report in Codecov by Sentry. |
trexfeathers
approved these changes
Feb 13, 2024
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
This is great, thanks @bouweandela. LGTM
acchamber
added a commit
to acchamber/iris
that referenced
this pull request
Feb 14, 2024
…into shapefile_masking * 'shapefile_masking' of https://github.com/acchamber/iris: [pre-commit.ci] pre-commit autoupdate (SciTools#5739) DOCS: Add whatsnew for ruff pydocstyle compliance (SciTools#5700) update docstring (SciTools#5737) Updated environment lockfiles (SciTools#5738) Add What's New entry. Consider NaNs equal when comparing cubes (SciTools#5713)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Feb 20, 2024
…umpydoc-pre-commit * 'numpydoc-pre-commit' of github.com:tkknight/iris: Update CF standard names to v84. (SciTools#5761) Regrid docs fix (SciTools#5758) Improve ncdata and CF information on "iris heart xarray" page (SciTools#5752) Pin ASV - airspeed-velocity/asv#1385. (SciTools#5756) Normalise units of coordinate bounds (SciTools#5746) Add "Which Regridder?" Documentation (SciTools#5742) Document `Coord.ignore_axis` (SciTools#5744) Disable navidation with keys for docs HTML theme options (SciTools#5747) Shapefile masking (SciTools#5470) [pre-commit.ci] pre-commit autoupdate (SciTools#5739) DOCS: Add whatsnew for ruff pydocstyle compliance (SciTools#5700) update docstring (SciTools#5737) Updated environment lockfiles (SciTools#5738) Consider NaNs equal when comparing cubes (SciTools#5713)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Consider NaNs equal when comparing cubes and speed up comparing cubes to themselves.
Closes #5705
Consult Iris pull request check list