Use the SciTools app for labeler permissions#5773
Closed
trexfeathers wants to merge 3 commits intoSciTools:mainfrom
Closed
Use the SciTools app for labeler permissions#5773trexfeathers wants to merge 3 commits intoSciTools:mainfrom
trexfeathers wants to merge 3 commits intoSciTools:mainfrom
Conversation
Contributor
Author
|
Looking at other examples, the label needs to be added by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5773 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 92 92
Lines 22940 22940
Branches 5462 5462
=======================================
Hits 20588 20588
Misses 1620 1620
Partials 732 732 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I don't think this a go-er, based on the fact that others haven't been able to get it working with pull requests, and that I reckon it's SciTools/workflows#28 or bust |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Ran into this problem when testing - benchmarks didn't trigger despite being labelled (#5772).
Logic dictates that we should test this, given the previous problem, but I don't know how that can be achieved given we need the App which is only on SciTools. I might try using
pull_requestinstead ofpull_request_target, in case the App gets round some of the other permissions...Consult Iris pull request check list