ASV custom build command and file-based benchmark triggers#5776
Merged
HGWright merged 22 commits intoSciTools:mainfrom Feb 27, 2024
Merged
ASV custom build command and file-based benchmark triggers#5776HGWright merged 22 commits intoSciTools:mainfrom
HGWright merged 22 commits intoSciTools:mainfrom
Conversation
trexfeathers
added
Type: Performance
Type: Testing
benchmark_this
trexfeathers
added
benchmark_this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5776 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 92 92
Lines 22940 22940
Branches 5462 5462
=======================================
Hits 20588 20588
Misses 1620 1620
Partials 732 732 ☔ View full report in Codecov by Sentry. |
Contributor
Performance Benchmark Report: 0822457Performance shiftsFull benchmark resultsGenerated by GHA run |
trexfeathers
added
the
benchmark_this
trexfeathers
added
benchmark_this
trexfeathers
added
benchmark_this
github-actions
bot
added
the
benchmark_this
trexfeathers
removed
the
benchmark_this
trexfeathers
added
the
benchmark_this
trexfeathers
changed the title
trexfeathers
added
benchmark_this
Contributor
⏱️ Performance Benchmark Report: 1b43151Performance shiftsFull benchmark resultsGenerated by GHA run |
trexfeathers
commented
Feb 27, 2024
trexfeathers
commented
Feb 27, 2024
trexfeathers
commented
Feb 27, 2024
trexfeathers
changed the title
HGWright
requested changes
Feb 27, 2024
Contributor
HGWright
left a comment
HGWright
left a comment
There was a problem hiding this comment.
Thanks @trexfeathers, a few changes as we discussed. But this should make it a lot easier to keep track of and own performance regressions.
HGWright
approved these changes
Feb 27, 2024
Contributor
HGWright
left a comment
HGWright
left a comment
There was a problem hiding this comment.
Thanks for making those changes @trexfeathers!
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Feb 27, 2024
* main: ASV custom build command and file-based benchmark triggers (SciTools#5776) DOCS: Enable numpydoc validation pre-commit hook (SciTools#5762) RUFF: fix legacy use of np.numpy.random (SciTools#5786)
Contributor
Author
|
Many thanks, @HGWright 🙂 |
This was referenced Feb 27, 2024
stephenworsley
pushed a commit
to stephenworsley/iris
that referenced
this pull request
Mar 11, 2024
…5776) * Trigger benchmarks if lock files have changed. * Check for 'true' string not boolean * Temporarily disable other CI. * Limit branch actions to pull requests * Unified continue check. * Benchmarks temporary debug mode. * Demonstrate lock file trigger for benchmarks. * Demonstrate overnight mode. * Revert "Demonstrate overnight mode." This reverts commit fbb4ab7. * Revert "Demonstrate lock file trigger for benchmarks." This reverts commit 5522251. * Minor visual improvements. * Explanatory notes. * Revert "Benchmarks temporary debug mode." This reverts commit 8f097b1. * Revert "Temporarily disable other CI." This reverts commit 621a774. * Fix docs indentation. * Custom ASV build command using setup.py. * Remove ASV pin. * Don't trigger benchmarks when pyproject.toml changes. * More accurate name for files-changed step. * Don't have a continue output. * Remove confusing variable name clash. * Update What's New entry.
pp-mo
pushed a commit
to pp-mo/iris
that referenced
this pull request
Mar 11, 2024
…5776) * Trigger benchmarks if lock files have changed. * Check for 'true' string not boolean * Temporarily disable other CI. * Limit branch actions to pull requests * Unified continue check. * Benchmarks temporary debug mode. * Demonstrate lock file trigger for benchmarks. * Demonstrate overnight mode. * Revert "Demonstrate overnight mode." This reverts commit fbb4ab7. * Revert "Demonstrate lock file trigger for benchmarks." This reverts commit 5522251. * Minor visual improvements. * Explanatory notes. * Revert "Benchmarks temporary debug mode." This reverts commit 8f097b1. * Revert "Temporarily disable other CI." This reverts commit 621a774. * Fix docs indentation. * Custom ASV build command using setup.py. * Remove ASV pin. * Don't trigger benchmarks when pyproject.toml changes. * More accurate name for files-changed step. * Don't have a continue output. * Remove confusing variable name clash. * Update What's New entry.
pp-mo
pushed a commit
to pp-mo/iris
that referenced
this pull request
Mar 11, 2024
…5776) * Trigger benchmarks if lock files have changed. * Check for 'true' string not boolean * Temporarily disable other CI. * Limit branch actions to pull requests * Unified continue check. * Benchmarks temporary debug mode. * Demonstrate lock file trigger for benchmarks. * Demonstrate overnight mode. * Revert "Demonstrate overnight mode." This reverts commit fbb4ab7. * Revert "Demonstrate lock file trigger for benchmarks." This reverts commit 5522251. * Minor visual improvements. * Explanatory notes. * Revert "Benchmarks temporary debug mode." This reverts commit 8f097b1. * Revert "Temporarily disable other CI." This reverts commit 621a774. * Fix docs indentation. * Custom ASV build command using setup.py. * Remove ASV pin. * Don't trigger benchmarks when pyproject.toml changes. * More accurate name for files-changed step. * Don't have a continue output. * Remove confusing variable name clash. * Update What's New entry.
HGWright
added a commit
to HGWright/iris
that referenced
this pull request
Mar 27, 2024
* 'geo-bridge' of github.com:HGWright/iris: (41 commits) Updated lock files. [pre-commit.ci] auto fixes from pre-commit.com hooks Advertise structured_um_loading performance regression. [pre-commit.ci] pre-commit autoupdate Updated environment lockfiles [pre-commit.ci] auto fixes from pre-commit.com hooks [pre-commit.ci] pre-commit autoupdate Make the bugfix panel OPEN. What's New patch. What's New patch. Bump scitools/workflows from 2024.03.1 to 2024.03.3 Bump scitools/workflows from 2024.03.0 to 2024.03.1 Bump scitools/workflows from 2024.02.2 to 2024.03.0 Fix usage of map_blocks in AreaWeighted and elsewhere (SciTools#5767) Lazy rolling_window (SciTools#5775) whatsnew update for 3.8.0 (SciTools#5793) Bump scitools/workflows from 2024.02.1 to 2024.02.2 (SciTools#5792) DOCS: Add whatsnew for recent PRs (SciTools#5789) ASV custom build command and file-based benchmark triggers (SciTools#5776) DOCS: Enable numpydoc validation pre-commit hook (SciTools#5762) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
build_commandinasv.conf.jsonto use Iris'setup.pyfileConsult Iris pull request check list