Replace DelegatedConda with Delegated#5963
Merged
ESadek-MO merged 14 commits intoSciTools:mainfrom Jun 28, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5963 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 90 90
Lines 22984 22984
Branches 5031 5031
=======================================
Hits 20634 20634
Misses 1619 1619
Partials 731 731 ☔ View full report in Codecov by Sentry. |
Contributor
⏱️ Performance Benchmark Report: f5bf5b7Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: 7c75a23Performance shiftsFull benchmark resultsGenerated by GHA run |
trexfeathers
commented
May 21, 2024
trexfeathers
commented
May 22, 2024
trexfeathers
commented
Jun 3, 2024
trexfeathers
commented
Jun 26, 2024
Contributor
Author
|
Hoping to have this in by |
ESadek-MO
requested changes
Jun 27, 2024
ESadek-MO
approved these changes
Jun 28, 2024
Contributor
ESadek-MO
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @trexfeathers!
Contributor
Author
|
Thanks @ESadek-MO! |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 18, 2024
* upstream/main: Quieter datum warning (SciTools#6050) Allow MeshCoord to have a coord-system (SciTools#6016) Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053) Faster concatenation of cubes with `AuxCoordFactory`s (SciTools#6038) Shorten cube iterator tests (SciTools#6041) Bump scitools/workflows from 2024.07.0 to 2024.07.1 (SciTools#6045) Bump scitools/workflows from 2024.06.5 to 2024.07.0 (SciTools#6034) Update test_Saver__ugrid.py (SciTools#6017) NEP29 and NumPy v2 pins (SciTools#6039) Adapt setup.py for pypa/setuptools@2db55275f. (SciTools#6036) Replace DelegatedConda with Delegated (SciTools#5963) Enable type hint checking (SciTools#5956) Bump scitools/workflows from 2024.06.4 to 2024.06.5 (SciTools#6026) Do not realize cell measures and ancillary variables in concatenate (SciTools#6010) [pre-commit.ci] pre-commit autoupdate (SciTools#6022) Bump scitools/workflows from 2024.06.3 to 2024.06.4 (SciTools#6018)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This new approach to managing our benchmark environments provides:
asv.plugins.conda.Conda, which merited several adaptations to get that particular setup to work. Now we just subclass the coreasv.environments.Environment.asv.conf.jsonstructure to avoid 'coupling' between separate config items.asv.conf.jsonmakes it possible to benchmark commits that need different environment setup commands (e.g. different Nox calls for different Python versions).Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: