Specify meta in dask.array.map_blocks#5989
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5989 +/- ##
=======================================
Coverage 89.87% 89.88%
=======================================
Files 88 88
Lines 23306 23315 +9
Branches 4336 4338 +2
=======================================
+ Hits 20947 20956 +9
Misses 1628 1628
Partials 731 731 ☔ View full report in Codecov by Sentry. |
|
Hmm linkcheck fail is this one... The website really is down right now :-( |
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
This does seem basically sound, but I have a couple of worries to raise.
We can go with this if you don't like the suggestions.
|
@pp-mo This is ready for another review. The readthedocs build appears to be failing because it tries to download shapefiles from a server that is offline. |
|
Thanks for your patience @bouweandela ! |
* upstream/main: (194 commits) Restore latest Whats New files. [pre-commit.ci] pre-commit autoupdate (SciTools#6205) correct major minor in whatsnew (SciTools#6202) What's new updates for v3.11.0rc0 . (SciTools#6201) Update CF standard names table. (SciTools#6200) Specify meta in dask.array.map_blocks (SciTools#5989) added in a vertical rule for surface fields (SciTools#5734) Updated environment lockfiles (SciTools#6197) Reduce duplication in cf.py spanning checks. (SciTools#6196) Fix attribute array comparison (SciTools#6181) Enable factory references to create new dimensions on load. (SciTools#6168) (SciTools#6194) Improve handling of masks in concatenate (SciTools#6187) Demo Numpy v2 (SciTools#6035) Bump scitools/workflows from 2024.10.1 to 2024.10.2 (SciTools#6186) Document use of new_axis to control merge (SciTools#6180) Updated environment lockfiles (SciTools#6184) [pre-commit.ci] pre-commit autoupdate (SciTools#6175) Updated environment lockfiles (SciTools#6183) Update to `cell_method` parsing (SciTools#6083) Bump scitools/workflows from 2024.10.0 to 2024.10.1 (SciTools#6179) ...
* Specify meta in da.map_blocks * Improve tests * Add more tests * Add whatsnew * Specify dtype in map_complete_blocks and undo change to lazy_elementwise --------- Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
2 participants
🚀 Pull Request
Description
Specify meta in
dask.array.map_blocksto avoid having the wrong chunktype in the output array.Closes #5988
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: