Added more descriptive errors within concatenate#6005
Merged
trexfeathers merged 5 commits intoSciTools:mainfrom Jun 14, 2024
Merged
Added more descriptive errors within concatenate#6005trexfeathers merged 5 commits intoSciTools:mainfrom
trexfeathers merged 5 commits intoSciTools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6005 +/- ##
==========================================
+ Coverage 89.75% 89.78% +0.03%
==========================================
Files 90 90
Lines 22929 22938 +9
Branches 5020 5023 +3
==========================================
+ Hits 20580 20595 +15
+ Misses 1618 1612 -6
Partials 731 731 ☔ View full report in Codecov by Sentry. |
trexfeathers
requested changes
Jun 14, 2024
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Nice work, and glad to see @rcomer likes it too!
Some comments for you
trexfeathers
approved these changes
Jun 14, 2024
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jun 20, 2024
* upstream/main: (42 commits) Mesh saveload fix (SciTools#6004) used tabs for the install info (SciTools#6013) Fix array_equal behaviour for masked arrays (SciTools#4457) Bump scitools/workflows from 2024.06.1 to 2024.06.2 (SciTools#6008) [pre-commit.ci] pre-commit autoupdate (SciTools#6007) Updated environment lockfiles (SciTools#5996) Added more descriptive errors within concatenate (SciTools#6005) Bump scitools/workflows from 2024.06.0 to 2024.06.1 (SciTools#5998) [pre-commit.ci] pre-commit autoupdate (SciTools#5997) Bump scitools/workflows from 2024.05.1 to 2024.06.0 (SciTools#5986) [pre-commit.ci] pre-commit autoupdate (SciTools#5980) Updated environment lockfiles (SciTools#5983) Bump scitools/workflows from 2024.05.0 to 2024.05.1 (SciTools#5984) Make `slices_over` tests go faster (SciTools#5973) Updated environment lockfiles (SciTools#5979) Update lock files with associated fixes (SciTools#5953) List 25 slowest tests (SciTools#5969) used a note to highlight some text (SciTools#5971) Lazy `iris.cube.Cube.rolling_window` (SciTools#5795) Add memory benchmarks (SciTools#5960) ...
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jun 23, 2024
* upstream/main: (143 commits) Updated environment lockfiles (SciTools#6020) Add `MeshCoord.collapsed` (SciTools#6003) Bump scitools/workflows from 2024.06.2 to 2024.06.3 (SciTools#6015) Mesh saveload fix (SciTools#6004) used tabs for the install info (SciTools#6013) Fix array_equal behaviour for masked arrays (SciTools#4457) Bump scitools/workflows from 2024.06.1 to 2024.06.2 (SciTools#6008) [pre-commit.ci] pre-commit autoupdate (SciTools#6007) Updated environment lockfiles (SciTools#5996) Added more descriptive errors within concatenate (SciTools#6005) Bump scitools/workflows from 2024.06.0 to 2024.06.1 (SciTools#5998) [pre-commit.ci] pre-commit autoupdate (SciTools#5997) Bump scitools/workflows from 2024.05.1 to 2024.06.0 (SciTools#5986) [pre-commit.ci] pre-commit autoupdate (SciTools#5980) Updated environment lockfiles (SciTools#5983) Bump scitools/workflows from 2024.05.0 to 2024.05.1 (SciTools#5984) Make `slices_over` tests go faster (SciTools#5973) Updated environment lockfiles (SciTools#5979) Update lock files with associated fixes (SciTools#5953) List 25 slowest tests (SciTools#5969) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5683.