Skip to content

BUG: creating coordinate from another crs copy#614

Merged
esc24 merged 1 commit intoSciTools:masterfrom
cpelley:coord_from_coord_bug
Jul 16, 2013
Merged

BUG: creating coordinate from another crs copy#614
esc24 merged 1 commit intoSciTools:masterfrom
cpelley:coord_from_coord_bug

Conversation

@cpelley
Copy link

@cpelley cpelley commented Jul 15, 2013

Currently, creating a coordinate from another using the coordinates
from_coord static method, passes the coordinate system through by
reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing that the new AuxCoord instance is not the original DimCoord instance. I think you intended something more like: self.assertIsNot(a.coord_system, b.coord_system).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, right you are

Currently, creating a coordinate from another using the coordinates
from_coord static method, passes the coordinate system through by
reference.
esc24 added a commit that referenced this pull request Jul 16, 2013
BUG: creating coordinate from another crs copy
@esc24 esc24 merged commit 6c1fc61 into SciTools:master Jul 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants