date_microseconds FUTURE flag#6260
Merged
stephenworsley merged 14 commits intoSciTools:mainfrom Dec 17, 2024
Merged
Conversation
for more information, see https://pre-commit.ci
trexfeathers
added
the
benchmark_this
trexfeathers
commented
Dec 17, 2024
Contributor
⏱️ Performance Benchmark Report: 62e8bafPerformance shiftsFull benchmark resultsGenerated by GHA run |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6260 +/- ##
==========================================
- Coverage 89.83% 89.81% -0.02%
==========================================
Files 88 88
Lines 23315 23347 +32
Branches 4338 4344 +6
==========================================
+ Hits 20945 20970 +25
- Misses 1644 1649 +5
- Partials 726 728 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Linkcheck should be fixed by #6261 |
Contributor
Author
|
The lack of coverage is only because we're testing against cf-units version 3.2 in this PR. |
trexfeathers
commented
Dec 17, 2024
bouweandela
reviewed
Dec 17, 2024
stephenworsley
requested changes
Dec 17, 2024
Contributor
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Looks good in theory, though I think there's a way to achieve this without changing the behaviour of cf_units for code outside of iris by limiting this to a change in the Unit class which iris objects have as their units attribute.
stephenworsley
approved these changes
Dec 17, 2024
Contributor
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Nice one. This looks a lot more robust now.
stephenworsley
added a commit
to stephenworsley/iris
that referenced
this pull request
Dec 17, 2024
…ask_slicing_bug * origin/pin_dask_slicing_bug: `date_microseconds` FUTURE flag (SciTools#6260) [pre-commit.ci] pre-commit autoupdate (SciTools#6259) Remove freepik.com link due to linkcheck breakage (SciTools#6261)
Contributor
Author
|
Thanks @stephenworsley! |
ESadek-MO
pushed a commit
to ESadek-MO/iris
that referenced
this pull request
Dec 19, 2024
* PoC monkeypatch precision. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add FUTURE flag. * FutureWarning. * Corrected behaviour and added tests. * Corrected behaviour and added tests. * What's New entry. * Make sensitive to cf-units version. * Further test improvements. * Clearer FutureWarning text. * Use a cf-units subclass instead. * Rename _IrisUnit to Unit. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merged
HGWright
pushed a commit
to HGWright/iris
that referenced
this pull request
Feb 28, 2025
* PoC monkeypatch precision. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add FUTURE flag. * FutureWarning. * Corrected behaviour and added tests. * Corrected behaviour and added tests. * What's New entry. * Make sensitive to cf-units version. * Further test improvements. * Clearer FutureWarning text. * Use a cf-units subclass instead. * Rename _IrisUnit to Unit. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
#6256 proves that this protects our tests, and our users, against the new precision introduced in cf-units version 3.3. Unfortunately that PR is blocked by other dependency issues that will be addressed elsewhere, so I want to introduce these code changes onto
mainindependently, which I have agreed with @stephenworsley.I will run the benchmarks to check whether my change was also responsible for the performance shifts in #6256.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: