Use realized data in benchmarks when requested#6339
Merged
pp-mo merged 3 commits intoSciTools:mainfrom Mar 6, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6339 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 90 90
Lines 23548 23548
Branches 4391 4391
=======================================
Hits 21143 21143
Misses 1662 1662
Partials 743 743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bouweandela
added
the
benchmark_this
Contributor
⏱️ Performance Benchmark Report: 2192362Performance shiftsFull benchmark resultsGenerated by GHA run |
This was referenced Feb 28, 2025
pp-mo
approved these changes
Mar 6, 2025
Member
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
Sorry, I should really have merged this one some time ago,
but I sort-of forgot it was not already done !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Benchmarking with realized data did not actually happen. This pull request updates the patch method so realized data is used in benchmarks that request it. Note that this does not apply to derived coordinates, which are always lazy.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: