Merged
Conversation
# Conflicts: # requirements/locks/py313-linux-64.lock
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
⏱️ Performance Benchmark Report: cb2e13aPerformance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: 01d8a48Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: 13438e9Performance shiftsFull benchmark resultsGenerated by GHA run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6342 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 90 90
Lines 23548 23548
Branches 4391 4391
=======================================
Hits 21143 21143
Misses 1662 1662
Partials 743 743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
⏱️ Performance Benchmark Report: 3240223Performance shiftsFull benchmark resultsGenerated by GHA run |
# Conflicts: # requirements/locks/py311-linux-64.lock # requirements/locks/py312-linux-64.lock # requirements/locks/py313-linux-64.lock
Contributor
⏱️ Performance Benchmark Report: ff2b196Performance shiftsFull benchmark resultsGenerated by GHA run |
ESadek-MO
requested changes
Feb 28, 2025
Contributor
ESadek-MO
left a comment
There was a problem hiding this comment.
Happy with all the changes, tests seem to work as they used to (as a bonus, is more readable in places too).
Only thing left is I think it might be worth mentioning this is the dependencies whatsnew, as the pin was mentioned there originally.
ESadek-MO
approved these changes
Feb 28, 2025
Contributor
⏱️ Performance Benchmark Report: 7bd7d0cPerformance shiftsFull benchmark resultsGenerated by GHA run |
ukmo-ccbunney
added a commit
to ukmo-ccbunney/iris
that referenced
this pull request
Feb 28, 2025
* upstream/main: Faster dimension lookup for derived coordinates (SciTools#6337) Unpin dask 2 (SciTools#6342) added classification enums to qp (SciTools#6346) Add castable check for valid_range, valid_min, valid_max. (SciTools#6343) Pin Sphinx below 8.2 (SciTools#6344) Add a text feature to quickplot (SciTools#6333)
This was referenced Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #6312.