Conversation
|
Since this branch now has merge conflicts and no one has commented yet I'll rebase ... |
There was a problem hiding this comment.
Would you consider moving this logic into add_dim_coords and add_aux_coords so other code can take advantage of it?
There was a problem hiding this comment.
hmm, actually it's not so applicable outside here.
There was a problem hiding this comment.
This logic only works when adding a bunch of coordinates in a single operation, so it isn't suitable for either of those methods. It's not possible to have a simple, persistent cache of identities simply because everything about a coordinate's identity is mutable!
|
If there's nothing else, are you happy for me to rebase now? |
|
Rebased from 418156c6664085a5344c85049f849b9159669bc2 to 336e4a1. |
This PR has two main aspects:
self.coords(coord=coord)check done byCube.add_dim_coords()andCube.add_aux_coords().Approx 7% performance boost doing iris.load_cubes() on a 17MB PP file containing 2048 fields.