Pp derived bounds mergedpaths by pp-mo · Pull Request #6483 · SciTools/iris

pp-mo · 2025-05-29T23:00:09Z

Proposed logic rework to #6481
For discussion
Only here, as a separate PR, to check if it broke any other tests...

(Update : added some further ideas (in followon commits) :

replace contextlib.suppress
replace try/except
improved(?) varnames + comments

)

pp-mo · 2025-05-29T23:07:03Z

OK tests look good,
so I hope that validates the logic of changes in b7dd7bc

codecov · 2025-05-29T23:09:43Z

Codecov Report

❌ Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.83%. Comparing base (da199ee) to head (8b6bc0c).
⚠️ Report is 213 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/iris/fileformats/cf.py	93.47%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6483      +/-   ##
==========================================
+ Coverage   89.79%   89.83%   +0.04%     
==========================================
  Files          90       90              
  Lines       23554    23826     +272     
  Branches     4391     4447      +56     
==========================================
+ Hits        21150    21404     +254     
- Misses       1662     1672      +10     
- Partials      742      750       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-05-29T23:57:12Z

⏱️ Performance Benchmark Report: `00eb6b9`

Performance shifts

Full benchmark results


Benchmarks that have stayed the same:

| Change   | Before [79272122]    | After [00eb6b93]    |   Ratio | Benchmark (Parameter)                                                                       |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------------------|
|          | 21.1±0.3ms           | 21.1±0.3ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 53.7±0.8ms           | 53.2±0.6ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 36.1±0.5ms           | 35.1±0.6ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 169±3ms              | 166±1ms             |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 23.2±0.5ms           | 22.9±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 32.5±0.3ms           | 31.6±0.2ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 23.5±0.5ms           | 23.6±0.7ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 32.0±0.6ms           | 31.8±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 21.0±0.4ms           | 21.3±0.4ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 45.2±0.4ms           | 44.7±0.7ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 127±1ms              | 126±0.9ms           |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 127±1ms              | 128±2ms             |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 22.3±0.3ms           | 22.4±0.7ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 48.9±1ms             | 48.4±1ms            |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 24.2±0.6ms           | 23.6±0.3ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                             |
|          | 58.5±0.8ms           | 58.0±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                              |
|          | 20.9±0.3ms           | 20.9±0.2ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 45.7±0.6ms           | 44.5±0.7ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.11±0.01s           | 1.08±0s             |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.08±0.01s           | 1.06±0.01s          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 218±3ms              | 216±3ms             |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 348±6ms              | 354±8ms             |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 22.0±0.3ms           | 22.5±0.3ms          |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 30.2±0.3ms           | 30.7±0.7ms          |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 22.5±0.4ms           | 23.0±0.6ms          |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 59.8±0.6ms           | 59.4±1ms            |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 23.5±0.5ms           | 23.6±0.3ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 61.7±0.6ms           | 61.7±1ms            |    1    | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 23.3±0.4ms           | 23.1±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 58.0±0.8ms           | 57.9±0.7ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 7.85±0.09ms          | 7.78±0.1ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 21.7±0.4ms           | 21.6±0.5ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 20.1±0.2ms           | 20.1±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 130±3ms              | 126±6ms             |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 8.21±0.06ms          | 8.15±0.08ms         |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 20.1±0.4ms           | 20.0±0.5ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 7.95±0.08ms          | 8.16±0.1ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 19.8±0.2ms           | 19.9±0.6ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 7.61±0.08ms          | 7.71±0.09ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 20.3±0.2ms           | 20.4±0.7ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 24.1±0.4ms           | 24.6±0.4ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 34.6±0.7ms           | 34.5±0.9ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 7.85±0.04ms          | 8.07±0.08ms         |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 20.8±0.2ms           | 20.7±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 9.36±0.1ms           | 9.31±0.09ms         |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 23.6±0.4ms           | 23.7±0.4ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 7.83±0.04ms          | 7.73±0.06ms         |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 20.3±0.4ms           | 20.6±0.3ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 529±4ms              | 528±3ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 538±4ms              | 538±5ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 46.6±0.4ms           | 46.7±0.8ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 138±3ms              | 133±3ms             |    0.96 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 8.02±0.08ms          | 7.90±0.04ms         |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 19.8±0.1ms           | 19.7±0.6ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 7.98±0.09ms          | 7.98±0.2ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 22.8±0.3ms           | 22.7±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 8.15±0.06ms          | 8.20±0.06ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 22.0±0.3ms           | 22.1±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 8.32±0.1ms           | 8.11±0.07ms         |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 21.7±0.4ms           | 21.6±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 23.0±0.4ms           | 22.5±0.4ms          |    0.98 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 84.2±0.9ms           | 83.3±0.5ms          |    0.99 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 22.9±0.3ms           | 23.1±0.2ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 96.1±1ms             | 95.1±1ms            |    0.99 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 21.5±0.3ms           | 21.8±0.4ms          |    1.02 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 56.1±0.6ms           | 56.0±0.8ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 8.14±0.07ms          | 8.32±0.06ms         |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 26.8±0.4ms           | 27.0±0.4ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 8.10±0.09ms          | 8.24±0.06ms         |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 28.4±0.6ms           | 28.3±0.4ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 7.85±0.1ms           | 7.92±0.09ms         |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 22.4±0.2ms           | 22.7±0.2ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 217±2ms              | 215±4ms             |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 276±2ms              | 275±2ms             |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.15±0.01ms          | 1.16±0.02ms         |    1    | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 399±2μs              | 402±6μs             |    1.01 | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 972±9μs              | 960±8μs             |    0.99 | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 573±8μs              | 578±6μs             |    1.01 | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 84.6±1ms             | 85.4±1ms            |    1.01 | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 26.4±1ms             | 25.6±1ms            |    0.97 | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 98.3±1ms             | 97.9±2ms            |    1    | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 17.2±0.2μs           | 18.1±0.4μs          |    1.05 | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 85.8±1ms             | 87.4±2ms            |    1.02 | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 26.6±0.4ms           | 28.0±1ms            |    1.05 | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 101±2ms              | 100±1ms             |    0.99 | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 17.2±0.3μs           | 17.6±0.5μs          |    1.02 | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 169±2ms              | 169±1ms             |    1    | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 68.1±1ms             | 67.9±0.8ms          |    1    | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 199±2ms              | 198±1ms             |    1    | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 53.6±0.3μs           | 54.1±0.3μs          |    1.01 | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 247±2ms              | 243±2ms             |    0.99 | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 140±3ms              | 140±3ms             |    1    | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 277±3ms              | 274±5ms             |    0.99 | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 55.7±0.8μs           | 56.1±0.8μs          |    1.01 | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 799±2μs              | 810±4μs             |    1.01 | import_iris.Iris.time__concatenate                                                          |
|          | 184±2μs              | 183±2μs             |    1    | import_iris.Iris.time__constraints                                                          |
|          | 114±2μs              | 114±0.7μs           |    1    | import_iris.Iris.time__data_manager                                                         |
|          | 91.3±1μs             | 92.5±0.8μs          |    1.01 | import_iris.Iris.time__deprecation                                                          |
|          | 163±3μs              | 161±0.6μs           |    0.99 | import_iris.Iris.time__lazy_data                                                            |
|          | 926±10μs             | 921±7μs             |    0.99 | import_iris.Iris.time__merge                                                                |
|          | 75.9±1μs             | 75.1±0.5μs          |    0.99 | import_iris.Iris.time__representation                                                       |
|          | 608±2μs              | 626±7μs             |    1.03 | import_iris.Iris.time_analysis                                                              |
|          | 142±3μs              | 141±1μs             |    0.99 | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 107±1μs              | 105±0.9μs           |    0.99 | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 245±2μs              | 248±3μs             |    1.01 | import_iris.Iris.time_analysis__interpolation                                               |
|          | 194±3μs              | 190±2μs             |    0.98 | import_iris.Iris.time_analysis__regrid                                                      |
|          | 113±1μs              | 110±0.6μs           |    0.98 | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 139±5μs              | 136±1μs             |    0.98 | import_iris.Iris.time_analysis_calculus                                                     |
|          | 325±2μs              | 326±10μs            |    1    | import_iris.Iris.time_analysis_cartography                                                  |
|          | 92.0±2μs             | 91.0±0.6μs          |    0.99 | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 209±2μs              | 211±2μs             |    1.01 | import_iris.Iris.time_analysis_maths                                                        |
|          | 94.4±0.7μs           | 95.0±0.7μs          |    1.01 | import_iris.Iris.time_analysis_stats                                                        |
|          | 171±0.6μs            | 173±1μs             |    1.01 | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 314±5μs              | 313±4μs             |    1    | import_iris.Iris.time_aux_factory                                                           |
|          | 81.3±0.2μs           | 81.5±0.9μs          |    1    | import_iris.Iris.time_common                                                                |
|          | 159±1μs              | 161±2μs             |    1.01 | import_iris.Iris.time_common_lenient                                                        |
|          | 1.38±0.01ms          | 1.37±0.01ms         |    1    | import_iris.Iris.time_common_metadata                                                       |
|          | 167±2μs              | 169±1μs             |    1.01 | import_iris.Iris.time_common_mixin                                                          |
|          | 1.17±0ms             | 1.18±0.01ms         |    1.01 | import_iris.Iris.time_common_resolve                                                        |
|          | 196±1μs              | 196±0.8μs           |    1    | import_iris.Iris.time_config                                                                |
|          | 127±3μs              | 127±2μs             |    1    | import_iris.Iris.time_coord_categorisation                                                  |
|          | 387±6μs              | 389±6μs             |    1.01 | import_iris.Iris.time_coord_systems                                                         |
|          | 768±8μs              | 767±7μs             |    1    | import_iris.Iris.time_coords                                                                |
|          | 647±10μs             | 646±9μs             |    1    | import_iris.Iris.time_cube                                                                  |
|          | 246±3μs              | 245±2μs             |    0.99 | import_iris.Iris.time_exceptions                                                            |
|          | 74.9±1μs             | 75.5±0.5μs          |    1.01 | import_iris.Iris.time_experimental                                                          |
|          | 182±0.8μs            | 181±1μs             |    1    | import_iris.Iris.time_fileformats                                                           |
|          | 255±2μs              | 257±2μs             |    1.01 | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.62±0.01ms          | 2.64±0.03ms         |    1.01 | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 76.1±0.7μs           | 76.2±0.2μs          |    1    | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 111±0.6μs            | 114±1μs             |    1.03 | import_iris.Iris.time_fileformats_abf                                                       |
|          | 426±7μs              | 436±3μs             |    1.02 | import_iris.Iris.time_fileformats_cf                                                        |
|          | 4.67±0.03ms          | 4.77±0.08ms         |    1.02 | import_iris.Iris.time_fileformats_dot                                                       |
|          | 71.7±0.7μs           | 71.8±1μs            |    1    | import_iris.Iris.time_fileformats_name                                                      |
|          | 247±2μs              | 249±3μs             |    1    | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 112±1μs              | 113±1μs             |    1.01 | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 121±0.7μs            | 120±2μs             |    1    | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 210±1μs              | 207±3μs             |    0.99 | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 794±7μs              | 816±6μs             |    1.03 | import_iris.Iris.time_fileformats_pp                                                        |
|          | 177±3μs              | 178±3μs             |    1.01 | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 134±0.6μs            | 134±0.6μs           |    1    | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 543±4μs              | 546±4μs             |    1.01 | import_iris.Iris.time_fileformats_rules                                                     |
|          | 221±3μs              | 222±1μs             |    1.01 | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 80.4±0.2μs           | 81.2±1μs            |    1.01 | import_iris.Iris.time_fileformats_um                                                        |
|          | 158±1μs              | 157±2μs             |    1    | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 136±2μs              | 136±0.9μs           |    1    | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 73.1±0.2μs           | 74.2±0.5μs          |    1.02 | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 78.8±0.5μs           | 79.0±1μs            |    1    | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 966±10μs             | 970±10μs            |    1    | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 137±0.9μs            | 139±1μs             |    1.02 | import_iris.Iris.time_io                                                                    |
|          | 176±4μs              | 179±5μs             |    1.02 | import_iris.Iris.time_io_format_picker                                                      |
|          | 210±3μs              | 211±1μs             |    1    | import_iris.Iris.time_iris                                                                  |
|          | 125±1μs              | 127±1μs             |    1.02 | import_iris.Iris.time_iterate                                                               |
|          | 8.15±0.06ms          | 8.15±0.02ms         |    1    | import_iris.Iris.time_palette                                                               |
|          | 1.76±0.04ms          | 1.78±0.01ms         |    1.01 | import_iris.Iris.time_plot                                                                  |
|          | 217±2μs              | 218±3μs             |    1    | import_iris.Iris.time_quickplot                                                             |
|          | 2.20±0.03ms          | 2.20±0.02ms         |    1    | import_iris.Iris.time_std_names                                                             |
|          | 1.84±0.05ms          | 1.81±0.01ms         |    0.99 | import_iris.Iris.time_symbols                                                               |
|          | 36.2±1ms             | 35.9±1ms            |    0.99 | import_iris.Iris.time_tests                                                                 |
|          | 253±6μs              | 250±0.6μs           |    0.99 | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 5.07±0.03ms          | 5.07±0.05ms         |    1    | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 118±1μs              | 118±0.4μs           |    1    | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.72±0.01ms          | 2.75±0.02ms         |    1.01 | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 1.30±0.01ms          | 1.31±0.01ms         |    1.01 | import_iris.Iris.time_third_party_numpy                                                     |
|          | 168±2μs              | 169±3μs             |    1    | import_iris.Iris.time_third_party_scipy                                                     |
|          | 97.5±1μs             | 99.5±0.8μs          |    1.02 | import_iris.Iris.time_time                                                                  |
|          | 347±3μs              | 352±6μs             |    1.02 | import_iris.Iris.time_util                                                                  |
|          | 73.0±1μs             | 73.7±0.4μs          |    1.01 | iterate.IZip.time_izip                                                                      |
|          | 9.73±0.09ms          | 9.58±0.03ms         |    0.98 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 15.8±0.2ms           | 15.9±0.3ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 9.59±0.04ms          | 9.59±0.03ms         |    1    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 9.52±0.03ms          | 9.57±0.03ms         |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 13.3±0.3ms           | 13.0±0.1ms          |    0.98 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 9.58±0.02ms          | 9.59±0.03ms         |    1    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.45±0.01s           | 1.44±0s             |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 11.9±0.3ms           | 12.0±0.1ms          |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.47±0.01s           | 1.45±0.01s          |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.44±0.01s           | 1.44±0.01s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 12.1±0.2ms           | 12.0±0.07ms         |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.46±0.01s           | 1.46±0.01s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 5.19±0.04ms          | 5.10±0.03ms         |    0.98 | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 11.7±0.07ms          | 11.7±0.1ms          |    1    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 5.05±0.01ms          | 5.08±0.08ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 5.12±0.03ms          | 5.08±0.02ms         |    0.99 | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 11.7±0.1ms           | 11.7±0.03ms         |    1    | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 5.12±0.04ms          | 5.02±0.03ms         |    0.98 | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 24.9±1ms             | 24.0±1ms            |    0.96 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 27.4±0.6ms           | 27.0±0.3ms          |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 12.5±2ms             | 12.5±2ms            |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 27.5±2ms             | 28.7±1ms            |    1.04 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 71.8±3ms             | 70.6±3ms            |    0.98 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 27.9±1ms             | 28.1±1ms            |    1.01 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 605±6ms              | 601±3ms             |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 3.52±0.1ms           | 3.48±0.1ms          |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 607±5ms              | 605±2ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 624±9ms              | 613±2ms             |    0.98 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 3.77±0.2ms           | 3.49±0.1ms          |    0.93 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 612±5ms              | 612±3ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 2.04±0.1ms           | 2.06±0.06ms         |    1.01 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 3.51±0.1ms           | 3.47±0.1ms          |    0.99 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 2.05±0.07ms          | 2.04±0.06ms         |    1    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 2.05±0.1ms           | 2.05±0.06ms         |    1    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 3.43±0.08ms          | 3.45±0.2ms          |    1    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 2.10±0.06ms          | 2.10±0.07ms         |    1    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 346±3ms              | 340±3ms             |    0.98 | load.ManyCubes.time_many_cube_load                                                          |
|          | 88.5±0.5ms           | 85.6±0.7ms          |    0.97 | load.ManyVars.time_many_var_load                                                            |
|          | 9.72±0.07ms          | 9.71±0.03ms         |    1    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 9.91±0.2ms           | 9.73±0.03ms         |    0.98 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.48±0.01s           | 1.46±0.01s          |    0.99 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.49±0.02s           | 1.47±0.01s          |    0.98 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 5.20±0.05ms          | 5.16±0.04ms         |    0.99 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 5.09±0.03ms          | 5.11±0.02ms         |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 8.98±0.1ms           | 8.64±0.05ms         |    0.96 | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 5.64±0.2ms           | 5.50±0.02ms         |    0.97 | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.44±0.01s           | 1.44±0.01s          |    0.99 | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 419±3ms              | 420±5ms             |    1    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.23±0.1ms           | 4.20±0.03ms         |    0.99 | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.16±0.09ms          | 4.14±0.02ms         |    0.99 | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 160±2ms              | 158±2ms             |    0.99 | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 14.8±0.3ms           | 15.3±0.4ms          |    1.03 | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 160±2ms              | 161±3ms             |    1.01 | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 32.0±0.5ms           | 31.8±0.9ms          |    1    | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 14.8±0.3ms           | 14.5±0.4ms          |    0.98 | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 31.9±0.3ms           | 32.3±0.4ms          |    1.01 | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 15.1±0.2ms           | 15.1±0.3ms          |    1    | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 45.7±0.7ms           | 46.2±0.9ms          |    1.01 | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 8.87±0.3ms           | 8.69±0.1ms          |    0.98 | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 16.5±0.2ms           | 17.2±0.4ms          |    1.04 | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 15.1±0.5ms           | 15.0±0.2ms          |    1    | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 15.1±0.4ms           | 15.9±0.4ms          |    1.06 | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 8.87±0.3ms           | 8.73±0.4ms          |    0.98 | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 11.5±0.2ms           | 11.6±0.6ms          |    1.01 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 15.8±0.2ms           | 16.2±0.3ms          |    1.03 | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 56.3±0.6ms           | 56.7±0.7ms          |    1.01 | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 15.8±0.2ms           | 15.9±0.1ms          |    1    | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 17.1±0.4ms           | 18.5±0.6ms          |    1.08 | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 3.34±0.2ms           | 3.40±0.1ms          |    1.02 | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 6.16±0.2ms           | 6.15±0.1ms          |    1    | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 36.3±1ms             | 35.2±0.7ms          |    0.97 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 766±8ms              | 765±6ms             |    1    | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 1.55±0.02s           | 1.54±0.04s          |    0.99 | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 434±5ms              | 432±5ms             |    0.99 | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 2.42±0G              | 2.42±0G             |    1    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 116±6M               | 111±5M              |    0.96 | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 36.4±0.6ms           | 34.9±3ms            |    0.96 | merge_concat.Merge.time_merge                                                               |
|          | 126±0.02M            | 126±0.02M           |    1    | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 363±10ns             | 365±2ns             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)              |
|          | 197±3ms              | 198±1ms             |    1.01 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 772±0.5k             | 772±0.6k            |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.2±0M              | 60.2±0M             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 16.8±0.2ms           | 16.8±0.2ms          |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 19.7±0.6ms           | 19.4±0.2ms          |    0.99 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 1.27±0.04M           | 1.27±0.04M          |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 25±0.04M             | 25±0.04M            |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 115±2ms              | 116±2ms             |    1.01 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 582±5ms              | 575±4ms             |    0.99 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.47±0.07M           | 1.47±0.02M          |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.5±0.03M           | 96.5±0.03M          |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 75.3±1ms             | 77.2±2ms            |    1.03 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 536±4ms              | 533±4ms             |    0.99 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.44±0.02M           | 1.43±0.03M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.5±0.02M           | 96.5±0.04M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997   | 2.1752849999999997  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998   | 216.01528499999998  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.79±0.06ms          | 6.71±0.05ms         |    0.99 | plot.AuxSort.time_aux_sort                                                                  |
|          | 82.1±2ms             | 81.5±2ms            |    0.99 | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M               | 136±3M              |    1    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 103±7ms              | 104±6ms             |    1.01 | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 57.2±0.6ms           | 58.2±1ms            |    1.02 | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 107±0.04M            | 107±0.04M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.04M            | 147±0.04M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.71±0.07ms          | 4.77±0.04ms         |    1.01 | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 81.4±0.7ms           | 80.2±1ms            |    0.99 | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 41.2±0.8ms           | 42.1±0.2ms          |    1.02 | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 476±5ms              | 470±3ms             |    0.99 | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 86.7±0.7ns           | 86.7±0.3ns          |    1    | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 63.6±0.6ms           | 62.8±1ms            |    0.99 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 86.8±0.4ns           | 87.0±0.4ns          |    1    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 418±4ms              | 412±3ms             |    0.99 | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 31.6±0.4k            | 31.6±0.4k           |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.87±0.1M            | 1.68±0.2M           |    0.9  | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 31.6±0.4k            | 31.6±0.4k           |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 225±30M              | 208±20M             |    0.92 | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 38.6±0.5ms           | 39.3±0.6ms          |    1.02 | stats.PearsonR.time_lazy                                                                    |
|          | 9.07±0.1ms           | 9.19±0.2ms          |    1.01 | stats.PearsonR.time_real                                                                    |
|          | 29.5±0.3M            | 29.5±0.6M           |    1    | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.4±0.01M           | 18.4±0.01M          |    1    | stats.PearsonR.tracemalloc_real                                                             |
|          | 24.9±0.6ms           | 24.5±0.4ms          |    0.98 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 60.5±0.8ms           | 60.0±0.5ms          |    0.99 | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 17.6±0.02M           | 17.6±0.02M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 7.75±0.02M           | 7.75±0.02M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Generated by GHA run 15335434940

pp-mo · 2025-05-30T08:42:09Z

Benchmark is also clean !
This covers the whole change, including all commits since @HGWright started the work on this

for more information, see https://pre-commit.ci

HGWright and others added 9 commits February 28, 2025 17:49

reuploading changes for bounds of derived variables

82be35f

New testing facilities (WIP temporary).

4d42439

Fixes?

905493f

Remove links for invalid derived bounds.

cc6183e

Updated tests for derived bounds : WIP working but more to do.

c35bdd1

Completed checks, tidied up and removed debug.

917818b

Replace test datafile with CDL in test.

ee74499

Remove redundant imports.

ad29c2b

Remerge split code sections for derived-bounds-handling/not.

b7dd7bc

pp-mo added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label May 29, 2025

scitools-ci bot added this to 🚴 Peloton May 30, 2025

Replace try-except; adjust some varnames and comments.

3061514

pp-mo force-pushed the pp_derived_bounds__mergedpaths branch from 7b1879f to 3061514 Compare May 30, 2025 10:10

[pre-commit.ci] auto fixes from pre-commit.com hooks

8b6bc0c

for more information, see https://pre-commit.ci

pp-mo closed this May 30, 2025

github-project-automation bot moved this to Done in 🚴 Peloton May 30, 2025

pp-mo deleted the pp_derived_bounds__mergedpaths branch June 12, 2025 16:43

scitools-ci bot removed this from 🚴 Peloton Jun 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pp derived bounds mergedpaths#6483

Pp derived bounds mergedpaths#6483
pp-mo wants to merge 11 commits intoSciTools:mainfrom
pp-mo:pp_derived_bounds__mergedpaths

pp-mo commented May 29, 2025 •

edited

Loading

Uh oh!

pp-mo commented May 29, 2025

Uh oh!

codecov bot commented May 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

pp-mo commented May 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pp-mo commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pp-mo commented May 29, 2025

Uh oh!

codecov bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented May 29, 2025

⏱️ Performance Benchmark Report: 00eb6b9

Uh oh!

pp-mo commented May 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pp-mo commented May 29, 2025 •

edited

Loading

codecov bot commented May 29, 2025 •

edited

Loading

⏱️ Performance Benchmark Report: `00eb6b9`