Skip to content

Bugfix array equality#6665

Merged
HGWright merged 31 commits intoSciTools:v3.12.xfrom
trexfeathers:bugfix_array_equality
Aug 21, 2025
Merged

Bugfix array equality#6665
HGWright merged 31 commits intoSciTools:v3.12.xfrom
trexfeathers:bugfix_array_equality

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Aug 20, 2025

Elementwise comparison is no longer permitted when NumPy shapes cannot be broadcast (I need to find an official reference for this).

Much of Iris is already protected behind various array_equal calls, this PR mops up the remaining ones.

Targetting v3.12.x as this is required as an urgent bugfix for some users of Iris 3.12. Can propagate afterwards as necessary.

@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (ffaaab9) to head (46f04fa).
⚠️ Report is 2 commits behind head on v3.12.x.

Files with missing lines Patch % Lines
lib/iris/util.py 90.90% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           v3.12.x    #6665      +/-   ##
===========================================
- Coverage    89.80%   89.80%   -0.01%     
===========================================
  Files           90       90              
  Lines        23752    23770      +18     
  Branches      4418     4419       +1     
===========================================
+ Hits         21331    21346      +15     
- Misses        1672     1678       +6     
+ Partials       749      746       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

trexfeathers and others added 15 commits August 20, 2025 13:41
@trexfeathers
Correct return type for masked_array_equal.
912e410
@trexfeathers
Protect _structured_array_identitication from elementwise equality.
7787980
@ukmo-ccbunney
Fixes for saver.py
b5da9a1
@trexfeathers
Protect pp.py from elementwise equality.
864f0d7
@trexfeathers
Protect pp_load_rules from elementwise equality.
37cb966
@trexfeathers
Merge branch 'bugfix_array_equality' of github.com:trexfeathers/iris …
a2557b8 
…into bugfix_array_equality
@trexfeathers
Revert "Protect pp.py from elementwise equality."
4a0eb4c 
This reverts commit 864f0d7.
@trexfeathers
Protect _concatenate from elementwise NOT equality.
6002908
@trexfeathers
Protect _constraints from elementwise NOT equality.
25b8604
@trexfeathers
Protect coords.py from elementwise NOT equality.
6d0287c
@trexfeathers
Protect cube.py from elementwise NOT equality.
4dfacf7
@trexfeathers
Protect util from elementwise NOT equality.
6208f4c
@trexfeathers
Add structured array test for NumPy elementwise broadcasting error.
fcce10e
@ukmo-ccbunney
Extra updates for pp_load_rules.py
b2e0566
@trexfeathers
Merge branch 'bugfix_array_equality' of github.com:trexfeathers/iris …
5749fdb 
…into bugfix_array_equality
trexfeathers
trexfeathers commented Aug 21, 2025
View reviewed changes
@HGWright HGWright added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Aug 21, 2025
trexfeathers
trexfeathers commented Aug 21, 2025
View reviewed changes
@trexfeathers trexfeathers added benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts and removed benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts labels Aug 21, 2025
@trexfeathers trexfeathers added benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts and removed benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts labels Aug 21, 2025
@trexfeathers trexfeathers marked this pull request as ready for review August 21, 2025 16:38
HGWright
HGWright approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval pending the completion of the benchmarks, and requires there to be no major slowdowns.

@HGWright HGWright merged commit 3c9112c into SciTools:v3.12.x Aug 21, 2025
24 of 26 checks passed
@HGWright
Copy link
Contributor

HGWright commented Aug 22, 2025

Benchmark Report Action Failed so here are the results.

⏱️ Performance Benchmark Report: 00e8b66

Performance shifts
Full benchmark results 

Benchmarks that have stayed the same:

| Change   | Before [ffaaab9f] <v3.12.2>   | After [00e8b66a]    |   Ratio | Benchmark (Parameter)                                                                       |
|----------|-------------------------------|---------------------|---------|---------------------------------------------------------------------------------------------|
|          | 21.1±0.2ms                    | 20.9±0.2ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 53.2±0.6ms                    | 52.7±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 35.3±0.3ms                    | 35.0±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 167±2ms                       | 166±3ms             |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 23.3±0.2ms                    | 23.2±0.3ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 31.5±0.3ms                    | 31.5±0.5ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 23.6±0.3ms                    | 23.2±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 31.9±0.1ms                    | 31.5±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 21.2±0.2ms                    | 20.7±0.2ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 45.9±0.5ms                    | 45.5±0.7ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 127±0.7ms                     | 126±1ms             |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 129±1ms                       | 130±0.7ms           |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 22.1±0.2ms                    | 22.4±0.2ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 48.1±0.5ms                    | 48.9±0.6ms          |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 23.5±0.4ms                    | 23.9±0.2ms          |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                             |
|          | 57.7±0.9ms                    | 57.7±0.7ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                              |
|          | 20.9±0.2ms                    | 21.0±0.1ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 45.5±0.7ms                    | 45.0±0.5ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.09±0.01s                    | 1.09±0s             |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.07±0.01s                    | 1.07±0.01s          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 215±5ms                       | 217±2ms             |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 349±6ms                       | 353±9ms             |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 21.9±0.6ms                    | 22.3±0.1ms          |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 30.1±0.4ms                    | 30.0±0.4ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 22.4±0.3ms                    | 22.2±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 60.5±0.8ms                    | 60.4±0.6ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 22.9±0.5ms                    | 23.3±0.2ms          |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 62.2±0.5ms                    | 62.8±0.8ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 23.1±0.4ms                    | 23.2±0.2ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 59.3±0.7ms                    | 58.9±0.8ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 7.83±0.06ms                   | 7.66±0.1ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 21.8±0.4ms                    | 22.0±0.1ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 19.3±0.3ms                    | 19.0±0.2ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 119±1ms                       | 120±2ms             |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 8.13±0.1ms                    | 8.00±0.1ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 20.2±0.2ms                    | 19.8±0.2ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 7.99±0.1ms                    | 7.99±0.07ms         |    1    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 19.9±0.3ms                    | 19.7±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 7.51±0.1ms                    | 7.56±0.05ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 20.7±0.4ms                    | 20.3±0.2ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 23.8±0.2ms                    | 23.7±0.2ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 34.1±0.3ms                    | 34.6±0.4ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 7.79±0.09ms                   | 7.76±0.1ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 21.0±0.1ms                    | 20.9±0.2ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 9.26±0.2ms                    | 9.33±0.07ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 23.5±0.4ms                    | 23.3±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 7.54±0.08ms                   | 7.75±0.1ms          |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 20.5±0.2ms                    | 20.6±0.4ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 529±3ms                       | 529±4ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 541±4ms                       | 536±2ms             |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 44.8±0.8ms                    | 45.1±0.3ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 132±3ms                       | 129±2ms             |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 7.86±0.1ms                    | 7.87±0.1ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 19.8±0.4ms                    | 20.0±0.3ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 7.91±0.07ms                   | 7.84±0.1ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 22.5±0.3ms                    | 22.6±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 8.03±0.1ms                    | 8.06±0.1ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 22.3±0.3ms                    | 22.4±0.4ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 8.17±0.1ms                    | 8.08±0.09ms         |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 22.0±0.2ms                    | 21.6±0.4ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 22.7±0.1ms                    | 22.6±0.2ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 83.1±0.6ms                    | 82.5±0.7ms          |    0.99 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 22.5±0.3ms                    | 22.7±0.2ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 95.4±1ms                      | 96.0±0.4ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 21.1±0.2ms                    | 21.6±0.2ms          |    1.02 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 56.1±0.7ms                    | 56.4±0.5ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 8.28±0.1ms                    | 8.23±0.06ms         |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 26.7±0.4ms                    | 26.9±0.5ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 8.04±0.08ms                   | 8.11±0.06ms         |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 28.3±0.5ms                    | 28.3±0.7ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 7.89±0.08ms                   | 7.82±0.09ms         |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 23.2±0.6ms                    | 23.3±0.7ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 217±1ms                       | 217±2ms             |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 268±3ms                       | 266±6ms             |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.09±0.02ms                   | 1.10±0.01ms         |    1.01 | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 385±5μs                       | 389±6μs             |    1.01 | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 929±9μs                       | 930±10μs            |    1    | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 558±6μs                       | 562±10μs            |    1.01 | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 84.5±1ms                      | 85.3±1ms            |    1.01 | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 26.2±0.9ms                    | 25.6±0.5ms          |    0.98 | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 98.8±1ms                      | 98.9±1ms            |    1    | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 16.3±0.3μs                    | 16.8±0.2μs          |    1.03 | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 85.6±1ms                      | 84.9±1ms            |    0.99 | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 25.8±0.8ms                    | 25.9±0.3ms          |    1.01 | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 101±2ms                       | 99.8±2ms            |    0.99 | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 16.4±0.2μs                    | 16.4±0.1μs          |    1    | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 171±2ms                       | 174±2ms             |    1.01 | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 67.2±1ms                      | 67.9±1ms            |    1.01 | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 197±4ms                       | 199±1ms             |    1.01 | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 51.2±0.2μs                    | 51.2±0.8μs          |    1    | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 242±6ms                       | 238±2ms             |    0.99 | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 135±2ms                       | 138±3ms             |    1.02 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 267±4ms                       | 269±6ms             |    1.01 | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 53.1±0.5μs                    | 53.4±0.9μs          |    1.01 | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 805±4μs                       | 803±6μs             |    1    | import_iris.Iris.time__concatenate                                                          |
|          | 189±3μs                       | 187±8μs             |    0.99 | import_iris.Iris.time__constraints                                                          |
|          | 115±2μs                       | 115±0.8μs           |    1    | import_iris.Iris.time__data_manager                                                         |
|          | 92.4±2μs                      | 91.2±0.8μs          |    0.99 | import_iris.Iris.time__deprecation                                                          |
|          | 163±1μs                       | 164±3μs             |    1.01 | import_iris.Iris.time__lazy_data                                                            |
|          | 909±20μs                      | 908±3μs             |    1    | import_iris.Iris.time__merge                                                                |
|          | 74.1±0.3μs                    | 74.7±0.8μs          |    1.01 | import_iris.Iris.time__representation                                                       |
|          | 624±7μs                       | 613±10μs            |    0.98 | import_iris.Iris.time_analysis                                                              |
|          | 139±1μs                       | 141±2μs             |    1.01 | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 106±0.6μs                     | 108±0.9μs           |    1.01 | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 249±2μs                       | 246±2μs             |    0.99 | import_iris.Iris.time_analysis__interpolation                                               |
|          | 193±3μs                       | 192±3μs             |    0.99 | import_iris.Iris.time_analysis__regrid                                                      |
|          | 112±2μs                       | 112±2μs             |    1    | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 137±0.6μs                     | 138±1μs             |    1    | import_iris.Iris.time_analysis_calculus                                                     |
|          | 323±3μs                       | 325±2μs             |    1.01 | import_iris.Iris.time_analysis_cartography                                                  |
|          | 91.1±0.4μs                    | 93.0±2μs            |    1.02 | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 212±1μs                       | 215±3μs             |    1.01 | import_iris.Iris.time_analysis_maths                                                        |
|          | 94.5±0.9μs                    | 95.9±0.8μs          |    1.02 | import_iris.Iris.time_analysis_stats                                                        |
|          | 170±2μs                       | 173±1μs             |    1.02 | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 316±5μs                       | 313±6μs             |    0.99 | import_iris.Iris.time_aux_factory                                                           |
|          | 81.0±0.5μs                    | 80.6±0.3μs          |    0.99 | import_iris.Iris.time_common                                                                |
|          | 159±2μs                       | 161±0.8μs           |    1.01 | import_iris.Iris.time_common_lenient                                                        |
|          | 1.38±0.01ms                   | 1.37±0.01ms         |    1    | import_iris.Iris.time_common_metadata                                                       |
|          | 168±2μs                       | 172±4μs             |    1.02 | import_iris.Iris.time_common_mixin                                                          |
|          | 1.18±0.01ms                   | 1.17±0ms            |    0.99 | import_iris.Iris.time_common_resolve                                                        |
|          | 200±1μs                       | 200±1μs             |    1    | import_iris.Iris.time_config                                                                |
|          | 127±4μs                       | 125±2μs             |    0.99 | import_iris.Iris.time_coord_categorisation                                                  |
|          | 393±10μs                      | 383±5μs             |    0.98 | import_iris.Iris.time_coord_systems                                                         |
|          | 774±6μs                       | 770±6μs             |    0.99 | import_iris.Iris.time_coords                                                                |
|          | 663±5μs                       | 673±20μs            |    1.01 | import_iris.Iris.time_cube                                                                  |
|          | 236±2μs                       | 236±5μs             |    1    | import_iris.Iris.time_exceptions                                                            |
|          | 74.3±0.3μs                    | 74.7±0.7μs          |    1    | import_iris.Iris.time_experimental                                                          |
|          | 181±1μs                       | 182±1μs             |    1.01 | import_iris.Iris.time_fileformats                                                           |
|          | 256±1μs                       | 255±1μs             |    1    | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.52±0.02ms                   | 2.57±0.02ms         |    1.02 | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 76.6±0.4μs                    | 76.9±1μs            |    1.01 | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 113±1μs                       | 112±0.9μs           |    1    | import_iris.Iris.time_fileformats_abf                                                       |
|          | 432±4μs                       | 438±9μs             |    1.01 | import_iris.Iris.time_fileformats_cf                                                        |
|          | 4.71±0.1ms                    | 4.83±0.09ms         |    1.02 | import_iris.Iris.time_fileformats_dot                                                       |
|          | 72.6±0.6μs                    | 72.0±1μs            |    0.99 | import_iris.Iris.time_fileformats_name                                                      |
|          | 251±4μs                       | 249±1μs             |    0.99 | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 113±0.6μs                     | 116±2μs             |    1.03 | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 120±0.9μs                     | 123±4μs             |    1.02 | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 205±4μs                       | 209±2μs             |    1.02 | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 801±5μs                       | 802±8μs             |    1    | import_iris.Iris.time_fileformats_pp                                                        |
|          | 178±2μs                       | 182±2μs             |    1.02 | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 134±0.8μs                     | 134±1μs             |    1    | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 547±2μs                       | 553±6μs             |    1.01 | import_iris.Iris.time_fileformats_rules                                                     |
|          | 225±7μs                       | 222±2μs             |    0.99 | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 80.7±1μs                      | 81.5±1μs            |    1.01 | import_iris.Iris.time_fileformats_um                                                        |
|          | 156±0.5μs                     | 160±4μs             |    1.02 | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 139±0.6μs                     | 141±3μs             |    1.01 | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 72.7±0.4μs                    | 73.1±1μs            |    1.01 | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 78.7±0.3μs                    | 79.4±1μs            |    1.01 | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 934±5μs                       | 942±10μs            |    1.01 | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 139±2μs                       | 138±3μs             |    1    | import_iris.Iris.time_io                                                                    |
|          | 177±0.7μs                     | 176±2μs             |    1    | import_iris.Iris.time_io_format_picker                                                      |
|          | 209±1μs                       | 208±1μs             |    1    | import_iris.Iris.time_iris                                                                  |
|          | 126±0.6μs                     | 127±2μs             |    1.01 | import_iris.Iris.time_iterate                                                               |
|          | 8.30±0.06ms                   | 8.20±0.2ms          |    0.99 | import_iris.Iris.time_palette                                                               |
|          | 1.76±0.06ms                   | 1.73±0.01ms         |    0.99 | import_iris.Iris.time_plot                                                                  |
|          | 220±1μs                       | 219±0.7μs           |    0.99 | import_iris.Iris.time_quickplot                                                             |
|          | 2.14±0.03ms                   | 2.16±0.02ms         |    1.01 | import_iris.Iris.time_std_names                                                             |
|          | 1.86±0.04ms                   | 1.84±0.02ms         |    0.99 | import_iris.Iris.time_symbols                                                               |
|          | 86.0±1ms                      | 86.3±1ms            |    1    | import_iris.Iris.time_tests                                                                 |
|          | 254±2μs                       | 255±3μs             |    1    | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 5.11±0.03ms                   | 5.07±0.04ms         |    0.99 | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 116±0.4μs                     | 118±0.6μs           |    1.01 | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.71±0.01ms                   | 2.78±0.02ms         |    1.02 | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 1.29±0.01ms                   | 1.29±0ms            |    1    | import_iris.Iris.time_third_party_numpy                                                     |
|          | 170±3μs                       | 169±1μs             |    0.99 | import_iris.Iris.time_third_party_scipy                                                     |
|          | 99.9±1μs                      | 99.4±2μs            |    0.99 | import_iris.Iris.time_time                                                                  |
|          | 353±8μs                       | 358±6μs             |    1.01 | import_iris.Iris.time_util                                                                  |
|          | 68.1±2μs                      | 71.6±1μs            |    1.05 | iterate.IZip.time_izip                                                                      |
|          | 10.1±0.1ms                    | 10.0±0.05ms         |    0.99 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 16.7±0.7ms                    | 15.8±0.7ms          |    0.95 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 9.97±0.1ms                    | 9.95±0.05ms         |    1    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 9.92±0.3ms                    | 9.98±0.1ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 13.2±0.4ms                    | 13.0±0.3ms          |    0.99 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 9.96±0.3ms                    | 10.0±0.09ms         |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.55±0.01s                    | 1.54±0.01s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 11.9±0.3ms                    | 12.2±0.4ms          |    1.02 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.55±0.01s                    | 1.56±0.01s          |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.54±0.01s                    | 1.56±0.02s          |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 11.9±0.4ms                    | 12.1±0.3ms          |    1.02 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.55±0.01s                    | 1.57±0.01s          |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 5.18±0.03ms                   | 5.22±0.06ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 11.7±0.5ms                    | 11.8±0.3ms          |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 5.15±0.06ms                   | 5.15±0.05ms         |    1    | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 5.22±0.02ms                   | 5.24±0.04ms         |    1    | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 11.9±0.4ms                    | 11.7±0.2ms          |    0.98 | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 5.18±0.04ms                   | 5.22±0.04ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 23.4±1ms                      | 25.5±1ms            |    1.09 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 28.1±0.7ms                    | 28.1±0.6ms          |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 11.8±0.8ms                    | 12.0±0.6ms          |    1.02 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 27.8±0.7ms                    | 27.5±0.8ms          |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 72.1±1ms                      | 71.3±0.6ms          |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 26.7±2ms                      | 26.7±0.7ms          |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 514±5ms                       | 513±4ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 3.13±0.2ms                    | 3.16±0.1ms          |    1.01 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 518±5ms                       | 519±4ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 523±5ms                       | 522±3ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 3.33±0.1ms                    | 3.28±0.2ms          |    0.98 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 519±6ms                       | 520±5ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 1.69±0.07ms                   | 1.61±0.07ms         |    0.95 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 3.28±0.1ms                    | 3.29±0.1ms          |    1    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 1.64±0.04ms                   | 1.63±0.05ms         |    0.99 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 1.67±0.06ms                   | 1.70±0.08ms         |    1.01 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 3.11±0.3ms                    | 3.32±0.1ms          |    1.07 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 1.63±0.07ms                   | 1.67±0.04ms         |    1.02 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 348±3ms                       | 350±3ms             |    1    | load.ManyCubes.time_many_cube_load                                                          |
|          | 87.1±0.8ms                    | 86.3±0.7ms          |    0.99 | load.ManyVars.time_many_var_load                                                            |
|          | 9.98±0.05ms                   | 10.1±0.06ms         |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 10.1±0.1ms                    | 10.1±0.07ms         |    1    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.54±0.01s                    | 1.56±0.01s          |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.56±0.01s                    | 1.58±0.01s          |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 5.16±0.05ms                   | 5.26±0.09ms         |    1.02 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 5.12±0.03ms                   | 5.18±0.04ms         |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 9.17±0.2ms                    | 9.19±0.07ms         |    1    | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 5.99±0.09ms                   | 5.91±0.06ms         |    0.99 | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.52±0.01s                    | 1.53±0.01s          |    1.01 | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 521±5ms                       | 526±3ms             |    1.01 | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.36±0.05ms                   | 4.37±0.03ms         |    1    | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.39±0.2ms                    | 4.26±0.03ms         |    0.97 | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 168±0.8ms                     | 170±2ms             |    1.02 | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 15.0±0.3ms                    | 15.3±0.3ms          |    1.02 | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 170±1ms                       | 171±0.8ms           |    1.01 | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 32.9±0.5ms                    | 32.9±0.8ms          |    1    | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 14.8±0.5ms                    | 15.1±0.5ms          |    1.02 | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 33.2±0.4ms                    | 33.4±1ms            |    1.01 | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 14.2±0.5ms                    | 13.9±0.4ms          |    0.98 | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 46.8±0.6ms                    | 45.7±0.5ms          |    0.98 | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 8.60±0.3ms                    | 8.65±0.2ms          |    1.01 | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 16.4±0.7ms                    | 16.5±0.3ms          |    1.01 | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 13.6±0.3ms                    | 14.0±0.2ms          |    1.03 | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 15.3±0.3ms                    | 16.1±0.8ms          |    1.05 | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 8.54±0.1ms                    | 8.70±0.1ms          |    1.02 | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 11.2±0.5ms                    | 11.8±0.7ms          |    1.05 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 14.8±0.2ms                    | 14.9±0.4ms          |    1.01 | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 56.1±1ms                      | 57.0±1ms            |    1.02 | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 14.9±0.4ms                    | 15.4±0.4ms          |    1.03 | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 17.4±0.3ms                    | 17.6±0.5ms          |    1.01 | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 3.30±0.07ms                   | 3.28±0.1ms          |    1    | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 4.63±0.1ms                    | 4.68±0.2ms          |    1.01 | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 41.1±1ms                      | 40.3±2ms            |    0.98 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 801±4ms                       | 802±7ms             |    1    | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 1.58±0.02s                    | 1.57±0.03s          |    0.99 | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 450±3ms                       | 452±5ms             |    1    | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 2.42±0G                       | 2.42±0G             |    1    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 110±2M                        | 110±2M              |    1    | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 34.8±2ms                      | 37.7±2ms            |    1.08 | merge_concat.Merge.time_merge                                                               |
|          | 126±0.01M                     | 126±0.01M           |    1    | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 338±5ns                       | 344±3ns             |    1.02 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)              |
|          | 197±3ms                       | 197±2ms             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 739±0.3k                      | 739±0.3k            |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.1±0M                       | 60.1±0M             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 16.6±0.3ms                    | 16.8±0.2ms          |    1.01 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 20.1±0.5ms                    | 20.1±0.2ms          |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 1.29±0M                       | 1.29±0M             |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 25±0M                         | 25±0M               |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 108±4ms                       | 107±3ms             |    0.98 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 577±6ms                       | 578±4ms             |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.35±0.04M                    | 1.35±0.05M          |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.4±0.06M                    | 96.4±0.06M          |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 68.3±1ms                      | 69.2±1ms            |    1.01 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 529±5ms                       | 533±5ms             |    1.01 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.25±0.03M                    | 1.25±0.03M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.3±0.03M                    | 96.3±0.04M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997            | 2.1752849999999997  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998            | 216.01528499999998  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.79±0.05ms                   | 6.89±0.09ms         |    1.01 | plot.AuxSort.time_aux_sort                                                                  |
|          | 79.7±5ms                      | 79.8±4ms            |    1    | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M                        | 136±3M              |    1    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 107±0.4ms                     | 108±0.6ms           |    1.01 | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 54.7±3ms                      | 54.1±3ms            |    0.99 | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 107±0.02M                     | 107±0.03M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.03M                     | 147±0.03M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.40±0.2ms                    | 4.48±0.05ms         |    1.02 | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 74.7±2ms                      | 76.2±1ms            |    1.02 | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 42.7±0.7ms                    | 43.1±0.6ms          |    1.01 | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 479±5ms                       | 485±4ms             |    1.01 | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 82.8±0.3ns                    | 83.1±0.3ns          |    1    | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 56.8±2ms                      | 57.3±0.5ms          |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 83.6±1ns                      | 83.8±0.6ns          |    1    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 424±6ms                       | 428±3ms             |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 29.8±0.3k                     | 29.6±0.2k           |    0.99 | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.8±0.1M                      | 1.8±0.2M            |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 29.6±0.3k                     | 29.7±0.3k           |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 208±20M                       | 225±30M             |    1.08 | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 39.8±0.5ms                    | 39.3±0.3ms          |    0.99 | stats.PearsonR.time_lazy                                                                    |
|          | 9.14±0.3ms                    | 9.05±0.2ms          |    0.99 | stats.PearsonR.time_real                                                                    |
|          | 29.2±0.8M                     | 30±0.9M             |    1.03 | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.4±0.01M                    | 18.4±0.01M          |    1    | stats.PearsonR.tracemalloc_real                                                             |
|          | 22.5±0.8ms                    | 22.2±0.5ms          |    0.99 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 61.8±0.9ms                    | 62.2±0.8ms          |    1.01 | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 17.6±0.02M                    | 17.6±0.02M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 7.74±0.02M                    | 7.74±0.01M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Generated by GHA run 17130909220

@bjlittle bjlittle mentioned this pull request Aug 26, 2025
Merged
@pp-mo pp-mo mentioned this pull request Sep 2, 2025
Merged
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HGWright HGWright HGWright approved these changes

@ukmo-ccbunney ukmo-ccbunney Awaiting requested review from ukmo-ccbunney

Assignees

No one assigned

Labels

benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts Release: Minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trexfeathers @HGWright @ukmo-ccbunney