Conversation
|
Issues with numpy 1.7.0b2 which are not present in 1.7.0 |
|
Let's go with pip for now, so we can continue with the 1.6.x release process. |
|
Done, cheers @bblay |
|
Please resubmit, I can't restart. |
|
Thanks for checking up on this for me @bblay |
|
I have just pushed back up |
|
Two doctest failures that you havene/t touched... I can't copy/paste the summary as travis won't let me get to the bottom of the page... Seems perverse to ask you to fix these 2 errors but I see no other reasonable option. |
|
Looks is a doc bug and the other looks like a change in behaviour with numpy where a repr of a numpy array containing a datetime object used to call its str but now it correctly calls its repr. |
|
Also fixes a few doc bugs. |
|
These changes will mean that some doctests will fail in future if running them with numpy <v1.7.0 |
|
Just checking whether the -I arg. in the pip install is necessary |
.travis.yml
Outdated
There was a problem hiding this comment.
@cpelley the -I ignores the already installed NumPy package ... is this the right way to nail down the version? Do we need to do this due to the apt-get of python-scipy and its pre-bundled version of NumPy?
Can you please justify the -I usage and at the very least add a comment for those that follow?
|
Confirmed that |
There was a problem hiding this comment.
tsk tsk ... @cpelley I assume you're going to push the change into code-generators?
There was a problem hiding this comment.
:)
https://github.com/SciTools/iris-code-generators/pull/33
I have done a diff between the one generated and the one that is in this PR, and they are identical.
|
Excellent @cpelley 👍, thanks! |
|
Thanks @cpelley |
Updated numpy to 1.7.2 in travis using the pypi package. Unofficial ppa available which is at v1.7.0b2 results in errors (don't want to hold up the release for this).