Skip to content

BLD: Updated numpy to 1.7.2#975

Merged
bjlittle merged 1 commit intoSciTools:masterfrom
cpelley:travis_numpy_update
Jan 23, 2014
Merged

BLD: Updated numpy to 1.7.2#975
bjlittle merged 1 commit intoSciTools:masterfrom
cpelley:travis_numpy_update

Conversation

@cpelley
Copy link

@cpelley cpelley commented Jan 22, 2014

Updated numpy to 1.7.2 in travis using the pypi package. Unofficial ppa available which is at v1.7.0b2 results in errors (don't want to hold up the release for this).

@cpelley
Copy link
Author

cpelley commented Jan 22, 2014

Issues with numpy 1.7.0b2 which are not present in 1.7.0
ValueError: negative dimensions are not allowed

@bblay
Copy link
Contributor

bblay commented Jan 22, 2014

Let's go with pip for now, so we can continue with the 1.6.x release process.
If we later find it causes Travis timeouts, we can disable the doctests in panic while we address it.

@cpelley
Copy link
Author

cpelley commented Jan 22, 2014

Done, cheers @bblay

@bblay
Copy link
Contributor

bblay commented Jan 22, 2014

Please resubmit, I can't restart.

$ ./.travis_no_output wget -O iris-test-data.zip https://github.com/SciTools/iris-test-data/archive/${IRIS_TEST_DATA_REF}.zip
Failed (exit code 8)
--2014-01-22 15:36:57-- https://github.com/SciTools/iris-test-data/archive/3378fe68c00ca7f31895ab6630a59a39ccef94e3.zip
Resolving github.com (github.com)... 192.30.252.129
Connecting to github.com (github.com)|192.30.252.129|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/SciTools/iris-test-data/zip/3378fe68c00ca7f31895ab6630a59a39ccef94e3 [following]
--2014-01-22 15:37:02-- https://codeload.github.com/SciTools/iris-test-data/zip/3378fe68c00ca7f31895ab6630a59a39ccef94e3
Resolving codeload.github.com (codeload.github.com)... 192.30.252.147
Connecting to codeload.github.com (codeload.github.com)|192.30.252.147|:443... connected.
HTTP request sent, awaiting response... 500 Internal Server Error
2014-01-22 15:37:26 ERROR 500: Internal Server Error.
The command "./.travis_no_output wget -O iris-test-data.zip https://github.com/SciTools/iris-test-data/archive/${IRIS_TEST_DATA_REF}.zip" failed and exited with 8 during install.
Your build has been stopped.

@cpelley
Copy link
Author

cpelley commented Jan 22, 2014

Thanks for checking up on this for me @bblay

@cpelley
Copy link
Author

cpelley commented Jan 22, 2014

I have just pushed back up

@bblay
Copy link
Contributor

bblay commented Jan 22, 2014

Two doctest failures that you havene/t touched...

/home/travis/build/SciTools/iris/docs/iris/src/whatsnew/1.5.rst:121: ERROR: Unexpected indentation.
/home/travis/.local/lib/python2.7/site-packages/iris/unit.py:docstring of iris.unit.Unit:14: ERROR: Unexpected indentation.

I can't copy/paste the summary as travis won't let me get to the bottom of the page...

Seems perverse to ask you to fix these 2 errors but I see no other reasonable option.

@cpelley
Copy link
Author

cpelley commented Jan 22, 2014

Looks is a doc bug and the other looks like a change in behaviour with numpy where a repr of a numpy array containing a datetime object used to call its str but now it correctly calls its repr.

@cpelley
Copy link
Author

cpelley commented Jan 22, 2014

Also fixes a few doc bugs.

@cpelley
Copy link
Author

cpelley commented Jan 23, 2014

These changes will mean that some doctests will fail in future if running them with numpy <v1.7.0

@cpelley
Copy link
Author

cpelley commented Jan 23, 2014

Just checking whether the -I arg. in the pip install is necessary

.travis.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpelley the -I ignores the already installed NumPy package ... is this the right way to nail down the version? Do we need to do this due to the apt-get of python-scipy and its pre-bundled version of NumPy?

Can you please justify the -I usage and at the very least add a comment for those that follow?

@cpelley
Copy link
Author

cpelley commented Jan 23, 2014

Confirmed that -I argument is not required for the pip install. I think this is specifically for previous pip installs of packages rather than any kind of interaction with existing system packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsk tsk ... @cpelley I assume you're going to push the change into code-generators?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)
https://github.com/SciTools/iris-code-generators/pull/33
I have done a diff between the one generated and the one that is in this PR, and they are identical.

@ghost ghost assigned bjlittle Jan 23, 2014
@bjlittle
Copy link
Member

Excellent @cpelley 👍, thanks!

bjlittle added a commit that referenced this pull request Jan 23, 2014
@bjlittle bjlittle merged commit 8e0ecc1 into SciTools:master Jan 23, 2014
@cpelley cpelley deleted the travis_numpy_update branch January 23, 2014 11:12
@bblay
Copy link
Contributor

bblay commented Jan 23, 2014

Thanks @cpelley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants