Enforce that NcAttribute.value is always an 0- or 1-D array.#106
Merged
Conversation
pp-mo
commented
Jan 14, 2025
pp-mo
force-pushed
the
attr_array_values
branch
from
2b91fa9 to
2f25a2c
Compare
pp-mo
added a commit
that referenced
this pull request
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103
This aligns with statements rashly made in advance, in #105 !
But we may still want to take out some remaining warnings there, about "attribute.value" not always being what you expected/wanted.
At least setting it is now "safe" : remove the "Why Not Just… set NcAttribute.value directly ?" section in the howtos