Conversation
Collaborator
@bjlittle used a label for this. So that you had to consciously say "this PR does not need a whatsnew". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whoops, mistake included with #136
The way the workflow is, if you do trial docs builds with 'make html', this makes changes to add a section in the changelog.
You need to remove those before you commit, but use of "git commit -a" means it's easy to miss.
FWIW this is also a good example of why we don't want to insist that all PRs should include a whatsnew
(which is a thing we could now add a CI check for).