fix: remove root version marker dependency from offline update flow#270
Merged
code-JDS merged 3 commits intoScience-Discovery:devfrom Apr 12, 2026
Merged
Conversation
Collaborator
|
/oc review |
Contributor
|
This PR removes the root
|
shellmind112
approved these changes
Apr 11, 2026
code-JDS
previously requested changes
Apr 11, 2026
Collaborator
code-JDS
left a comment
There was a problem hiding this comment.
请复核opencode review提出的问题是否确实存在
added 3 commits
April 11, 2026 23:17
Stop relying on the root .aether_web_version marker in linux and windows installer/update flows. Resolve installed versions from versioned package directories instead, and keep only per-version markers inside each installed package directory.
Resolve installed darwin versions from versioned package directories and per-package markers instead of the redundant root .aether_web_version file. Remove the root marker after updates so launcher and installer logic rely only on package-local version information.
Drop the redundant :active_dir fallback loop in update_windows.bat so version resolution no longer depends on an unset or stale DIR environment variable inside the inner PowerShell invocation.
7a15f34 to
e26c342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #269
Type of change
What does this PR do?
This removes the offline installer/update flow's dependency on the root
.aether_web_versionmarker.Instead of reading the root marker to decide which version is installed or active, the scripts now resolve versions from the installed package directories themselves. For darwin and linux, the update launchers, installer checks, and version pruning logic now derive versions from each
aether_<version>directory and its package-local marker. For windows, the installer and updater now do the same when checking installed versions, active versions, and retained versions.The root
.aether_web_versionfile is no longer written as part of the update flow. Existing stale copies are removed during install/update so version selection depends only on the package directories, which are the actual source of truth.How did you verify your code works?
bash -n Update/update_darwin.commandbash -n Update/aether_darwin_installer.commandbash -n Update/aether_darwin_installer_devtest.commandbash -n Update/update_linux.shbash -n Update/aether_linux_installer.shbash -n Update/aether_linux_installer_devtest.sh.aether_web_versionvalue did not affect the installed or launched versionScreenshots / recordings
Not applicable.
Checklist