Skip to content

Display the scroll functionality in the sidebar for testing issue #92…#6

Merged
lfoppiano merged 2 commits intomainfrom
feature/show-annotation-scroll
May 5, 2025
Merged

Display the scroll functionality in the sidebar for testing issue #92…#6
lfoppiano merged 2 commits intomainfrom
feature/show-annotation-scroll

Conversation

@t29mato
Copy link
Copy Markdown
Collaborator

@t29mato t29mato commented Apr 25, 2025

I've made this change to test the scroll of annotation.
ScienciaLAB/streamlit-pdf-viewer#92 (comment)

@t29mato t29mato requested a review from lfoppiano April 25, 2025 06:31
@lfoppiano
Copy link
Copy Markdown
Collaborator

I don't understand this PR. Is it for testing or it remove some changes for testing, that was made in a merged PR ?

@lfoppiano
Copy link
Copy Markdown
Collaborator

Ah, it's a different repo 🫨

lfoppiano
lfoppiano previously approved these changes Apr 25, 2025
@lfoppiano lfoppiano dismissed their stale review April 25, 2025 06:51

Too fast

@t29mato
Copy link
Copy Markdown
Collaborator Author

t29mato commented Apr 25, 2025

I was unsure whether to send this pull request to the Streamlit application, but I thought it might help test ScienciaLAB/streamlit-pdf-viewer#95. Whether you merge it or not depends on your strategy.

@lfoppiano
Copy link
Copy Markdown
Collaborator

OK, will merge as soon as the 0.0.23 is out.

@lfoppiano lfoppiano merged commit c161baa into main May 5, 2025
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants