Ping Protection V1.1

[Kevinking500]

This is a small update to the current Ping Protection module.
This update includes the following changes:

• [QOL] Updated some locales and improved some of their names
• [Bug] Fixed the automod default block message from being over the 150 characters limit
• [Bug] Fixed that the whitelisted users didn't show

I apologize for not catching these bugs in the initial release
No AI has been used this time.

[Fridolin012]

I noticed a few things I’d like to share regarding the module:

• Redundant Settings: In the "Moderation Actions" config, there’s a setting for "Pings to trigger moderation," but there’s also a custom function for it. It feels a bit messy to have both. I’d suggest just keeping the custom function ("custom timeframe") to make it cleaner.
• Log Retention: Why is the mod-log capped at 12 months? The moderation module doesn't have this limit, and I’m wondering if this can be changed to stay consistent with the rest of the tools.

[Kevinking500]

Hi Fridolin,
That is indeed a bit messy, I will change that.
For the log retention though, as this is a module for "only" pings and not otherwise a broad (multiple) rule breaking that can include a big variety of punishments like warnings, mutes, kicks, bans and things that it feels like having it more than 1 year for "only" pinging is a lot, but I can extend it if you feel like it would need to be more, or even do no limit.

[Fridolin012]

Hi,

thank you for your quick response. I think we should ask @SCDerox for the second question^^

[SCDerox]

Thanks for your valuable feedback, Fridolin. I, personally, have no issues with the limit. But based on your feedback, there's no technical reason that requires a limit. So making it adjustable and allowing users to disable it might be a compromise that both sides could agree on.

[Kevinking500]

I think I might just increase the limit to 2 years (48 months) and if we get any feedback from users for it to be longer then ig I can make it unlimited. But I agree with both 😅

[Kevinking500]

Alrighty, I have now set the pings history limit to 2 years (I actually relaized it was only 6 months max, that was indeed short). Additionally, I removed the pings count thing for the custom timeframe as that's basically useless, it now uses the standard one, which is now also renamed to pingsCount without the Basic.

[Kevinking500]

Sorry, I forgot you were talking about moderation log

[Kevinking500]

Hi, I quickly added the category feature in the configuration.json and storage.json config files to make it look more sleek ^^

[Kevinking500]

Thanks to Simon who provided me the list of emoji's that actually work in the dashboard, I adjusted it to use supported ones ^^

[SCDerox]

Hi, thanks so much for your contribution - quick update: Unfortunately I have exams this week, so it might take a few weeks to review everything. Thanks so much for your patience.

[Copilot]

Pull request overview

Updates the Ping Protection module’s configuration/UI text and fixes a missing “whitelisted users” display, while also adjusting some retention/default messaging behavior.

Changes:

• Add config UI grouping metadata (categories) to ping-protection configuration/storage config definitions.
• Fix /ping-protection list whitelisted to include whitelisted users and update related locale keys/strings.
• Simplify moderation trigger configuration (merge basic/advanced ping-count fields) and update the moderation evaluation logic accordingly.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
modules/ping-protection/ping-protection.js	Updates deletion log locale key, changes mod-log retention fallback, and simplifies moderation trigger count handling.
modules/ping-protection/events/interactionCreate.js	Updates modal success reply locale key for data deletion.
modules/ping-protection/configs/storage.json	Adds config categories and updates retention bounds/defaults; includes the ping-history wipe toggle definition.
modules/ping-protection/configs/moderation.json	Renames/removes ping-count fields for moderation rules (schema change).
modules/ping-protection/configs/configuration.json	Adds config categories and shortens the default AutoMod block message.
modules/ping-protection/commands/ping-protection.js	Updates embed field locale keys and adds whitelisted users to the list output.
locales/en.json	Renames/adds locale keys and updates descriptions/titles for the list and modal messages.

Comments suppressed due to low confidence (2)

modules/ping-protection/configs/moderation.json:29

• Renaming pingsCountBasic to pingsCount (and removing pingsCountAdvanced) is a breaking change for existing moderation.json config elements. The config loader only copies fields by name, so existing rule thresholds will be dropped and replaced with defaults on next startup/reload. Consider adding a migration (e.g., map old keys to the new one) or keeping legacy fields temporarily to preserve user configuration.

    {
      "name": "pingsCount",
      "humanName": {
        "en": "Pings to trigger moderation"
      },
      "description": {
        "en": "The amount of pings required to trigger a moderation action."
      },
      "type": "integer",
      "default": {
        "en": 10
      }
    },

modules/ping-protection/configs/storage.json:72

• The field is named deleteAllPingHistoryAfterTimeframe, but enforceRetention() checks storageConfig.DeleteAllPingHistoryAfterTimeframe (capital D). With the current mismatch, this toggle will never take effect and the code will always run the non-wipe branch. Align the property name in code/config so the setting actually works.

      "name": "deleteAllPingHistoryAfterTimeframe",
      "category": "pings",
      "humanName": {
        "en": "Delete all the pings in history after the timeframe?"
      },
      "description": {
        "en": "If enabled, the bot will delete ALL the pings history of an user after the timeframe instead of only the ping(s) exceeding the timeframe in the history."
      },

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[SCDerox]

No issues from my side, please address the small thing copilot found and then re-request a review to get this merged 😄

[Kevinking500]

I have done the suggested changes, I will quickly be testing the moderation rules to make sure it works with these changes, and then i'll commit it ^^

[Kevinking500]

I have found no bugs during the (fairly) short testing period of moderation actions ^^

[Kevinking500]

I also addressed the tab in the locales I forgot to do which was mentioned by Jan in his latest PR here ^^