Skip to content

Resolve github action issue (attempt 2)#35

Merged
c-riddoch merged 5 commits intomainfrom
fix_ci_issues
Oct 16, 2025
Merged

Resolve github action issue (attempt 2)#35
c-riddoch merged 5 commits intomainfrom
fix_ci_issues

Conversation

@ken-oneill
Copy link
Copy Markdown
Member

Proposal changes:

  1. Allow two tests for get_datazone_lookup() and get_simd_lookup() to skip GitHub Actions CI
  2. Set the 'opendatascot' R package as a development package rather than CRAN
  3. To avoid losing track of changes, the package version has been incremented to 0.2.0 to account for all previous changes including the new geography functions recently added - get_datazone_lookup(), get_simd_lookup(), get_sspl_lookup() and add_geography()
  4. In related to bullet point 4, a basic NEWS.md is created (quite late.)

The problems with GitHub Actions CI

As briefly described in the first two bullet points above, some GitHub Actions CI (standard) for R did not run successfully because (to the best of my knowledge):

  • the opendatascot package is not a CRAN package
  • two functions -- get_datazone_lookup() and get_simd_lookup() -- rely on a live SPARQL endpoint and then download a CSV file.

Expected outcome

All GitHub Actions CI for R should then pass.

Previous attempt(s)

One previous attempt tried to resolve the aforementioned GitHub Actions CI issues unsuccessfully - see the closed (not merged) pull request #31 which is almost identical to this request except that I did not account for the dependency on the config package the last time.

@ken-oneill
Copy link
Copy Markdown
Member Author

Update to the proposal changes section above:

  • Allow the test for add_geography to skip GitHub Actions CI because this test would also depend on get_datazone_lookup() too.

Copy link
Copy Markdown
Collaborator

@c-riddoch c-riddoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Particularly like the addition of news.md

@c-riddoch c-riddoch merged commit c617b59 into main Oct 16, 2025
5 checks passed
@c-riddoch c-riddoch deleted the fix_ci_issues branch October 16, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants