Conversation
Member
Author
Update to the proposal changes section above:
|
c-riddoch
approved these changes
Oct 16, 2025
Collaborator
c-riddoch
left a comment
There was a problem hiding this comment.
All good. Particularly like the addition of news.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal changes:
get_datazone_lookup()andget_simd_lookup()to skip GitHub Actions CIget_datazone_lookup(),get_simd_lookup(),get_sspl_lookup()andadd_geography()The problems with GitHub Actions CI
As briefly described in the first two bullet points above, some GitHub Actions CI (standard) for R did not run successfully because (to the best of my knowledge):
get_datazone_lookup()andget_simd_lookup()-- rely on a live SPARQL endpoint and then download a CSV file.Expected outcome
All GitHub Actions CI for R should then pass.
Previous attempt(s)
One previous attempt tried to resolve the aforementioned GitHub Actions CI issues unsuccessfully - see the closed (not merged) pull request #31 which is almost identical to this request except that I did not account for the dependency on the
configpackage the last time.