Split add geography#37
Conversation
|
Thank you @c-riddoch. I've made the following main changes:
I am content to keep I am also content to set I'd be grateful if you or other contributor could have a look at my changes first before approving this pull request. Ken |
zsofia-stefan
left a comment
There was a problem hiding this comment.
New additions to documentation (including package as well as function descriptions and news) are clear and helpful; revised version numbering made explicit. Each new function has been tested individually and they run smoothly, with helpful in-built error message to make sure formatting is carried out. Updates to corresponding test scripts are relevant and run well. No apparent typos or redundancies. Brilliant improvements across the board -- thank you.
This does what was asked by the equalities team ie splits the add_geography function so the cleaning of postcodes can happen long before the additional columns are added. By creating two new functions but calling them both inside the old function this should not be a breaking change ie no existing code using the add_geography function should break. There was a request to make the lookup files optional but the datazone_lookup is needed for the local authority names to be added. The simd_lookup has been made optional.
Commits not squashed because last time people found it useful to see them.