[Bounty #908] Implement /wallet/history with unified transfers + rewards#966
Closed
mtarcure wants to merge 1 commit intoScottcjn:mainfrom
Closed
[Bounty #908] Implement /wallet/history with unified transfers + rewards#966mtarcure wants to merge 1 commit intoScottcjn:mainfrom
mtarcure wants to merge 1 commit intoScottcjn:mainfrom
Conversation
The existing /wallet/history endpoint only returned transfers from pending_ledger. This merges epoch_rewards (mining payouts) into the response, adds offset pagination, and returns the expected format with ok/miner_id/transactions/total envelope. Fixes #775, #886. Bounty #908. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Thanks mtarcure! However, bounty #908 was already fulfilled by createkr's PR #945 (merged yesterday). Your unified history concept (transfers + rewards in one response) is a good enhancement idea — consider opening a new issue for it as a separate bounty. Your DriftLock stress test (#127 on shaprai) was excellent work — keep contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #908 (fixes #775, #886)
Summary
/wallet/historyto query bothpending_ledger(transfers) andepoch_rewards(mining payouts)offset/limitpagination{"ok": true, "miner_id": "...", "transactions": [...], "total": N}What changed
The existing endpoint only returned transfers. Now it also includes mining rewards with
type: "reward"and epoch metadata. All transactions are merged and sorted by timestamp descending.Transaction types
transfer_outpending_ledgertransfer_inpending_ledgerrewardepoch_rewardsExample response
🤖 Generated with Claude Code