Skip to content

Conversation

@mxmou
Copy link
Member

@mxmou mxmou commented Nov 26, 2023

Resolves #6862

Changes

Only changes the paint editor tool selector to a single column if there's enough space.

image image

Reason for changes

To make space for the backpack on small screens.

Tests

Tested on Edge and Firefox with different zoom levels and window sizes.

@mxmou mxmou added the scope: addon Related to one or multiple addons label Nov 26, 2023
@mxmou mxmou self-assigned this Nov 26, 2023
Copy link
Member

@WorldLanguages WorldLanguages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested succesfully in Chromium.
With my default screen size and zoom, I still have enough space for one column of vector tools.
Using Chrome Devtools' "device toolbar" set at Responsive 1300x640 the bug was fixed, as the vector tools now used 2 columns instead which left enough space for the backpack.

@mxmou mxmou added the status: needs review PR needs 1 more approval label Nov 26, 2023
@WorldLanguages WorldLanguages removed the status: needs review PR needs 1 more approval label Nov 28, 2023
@WorldLanguages WorldLanguages merged commit 314442c into ScratchAddons:master Nov 28, 2023
@mxmou mxmou deleted the fix-compact-backpack branch November 28, 2023 18:34
Samq64 pushed a commit to Jazza-231/ScratchAddons that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: addon Related to one or multiple addons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compact-editor: not enough room for backpack when on costumes tab

2 participants