blocks2image: support high contrast mode #6907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmou
force-pushed
the
blocks2image-contrast
branch
from
e457cf6 to
5d24adc
Compare
WorldLanguages
approved these changes
Nov 29, 2023
Member
WorldLanguages
left a comment
WorldLanguages
left a comment
There was a problem hiding this comment.
Fixes the bug on Chromium, original color theme continues to work properly
Samq64
approved these changes
Nov 30, 2023
Member
|
Fetching the same image multiple times can become slow. Thanks @Jazza-231 and @Samq64 for noticing this. |
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6663
Changes
Makes
blocks2imageuse black text and icons when high contrast mode is enabled.Reason for changes
To make the text readable.
Tests
Tested on Edge and Firefox.