Skip to content

Make the CI green again#23

Merged
ScriptedAlchemy merged 7 commits into
rudy-respondfrom
fix/ci
Aug 27, 2018
Merged

Make the CI green again#23
ScriptedAlchemy merged 7 commits into
rudy-respondfrom
fix/ci

Conversation

@hedgepigdaniel
Copy link
Copy Markdown
Collaborator

@hedgepigdaniel hedgepigdaniel commented Aug 26, 2018

  • Prettier must pass everywhere (yarn run prettify or yarn run lint --fix will always fix it)
  • Eslint must pass in the boilerplate. There is quite a bit more work to be done in the rudy package to make it pass.
  • Tests must pass
  • Snyk must pass
  • The build (as in, yarn run build) must complete in all packages

The import/no-unresolved eslint rule behaved differently on the CI server to my local setup - it originally passed for me.

@hedgepigdaniel
Copy link
Copy Markdown
Collaborator Author

Seems like travis runs the build and it passes, but then it doesn't report the result and the log is empty.

I know because if you cancel the build in the Travis UI, you can see the log (which shows that the script succeeded). Cancelling it makes it fail though :(

wut

@hedgepigdaniel
Copy link
Copy Markdown
Collaborator Author

hooray it passed!

@ScriptedAlchemy ScriptedAlchemy merged commit de0f308 into rudy-respond Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants