Skip to content

refactor: implement config class from utils#15

Merged
jlenon7 merged 1 commit intomainfrom
refactor/len-impl-config-utils
Mar 6, 2022
Merged

refactor: implement config class from utils#15
jlenon7 merged 1 commit intomainfrom
refactor/len-impl-config-utils

Conversation

@jlenon7
Copy link
Contributor

@jlenon7 jlenon7 commented Mar 6, 2022

Proposed changes

Implement Config class from @secjs/utils instead of @secjs/config.

This commit has a breaking change under Utils folder that has been renamed from utils to Utils

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@jlenon7 jlenon7 added documentation Improvements or additions to documentation refactor Refactor a past feature test Adding missing tests or correcting existing tests labels Mar 6, 2022
@jlenon7 jlenon7 requested a review from txsoura March 6, 2022 12:53
@jlenon7 jlenon7 self-assigned this Mar 6, 2022
@jlenon7 jlenon7 merged commit 642941c into main Mar 6, 2022
@jlenon7 jlenon7 deleted the refactor/len-impl-config-utils branch March 6, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation refactor Refactor a past feature test Adding missing tests or correcting existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments