Open
Conversation
Owner
|
I am in the middle of completely overhauling the entire system lol However, I will definitely keep this around and in mind for that overhaul to perhaps implement it during or not too long after. |
|
I'm curious how the overhaul is going. And also wondering if it would be useful to incorporate this PR in the meantime? I'm participating in a Firefly RPG campaign and trying to get the GM to use my Foundry server. It was pretty easy to build each of the actor types and I really liked how you dealt with the customization of Cortex Prime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to get initiative rolls working from the combat tracker. It looks for one or more rollable traits defined in the settings, and then searches through the character's trait sets for those, builds a roll formula and returns that as the combatant. If no traits are found it rolls a 1d20 by default.
Probably could use some caching/memoization for the trait lookup, since it could get expensive. Just curious what you think of the approach, I know the JavaScript doesn't really match your style.