automatically set the height of the tabs across the languages#1157
Merged
titusfortner merged 1 commit intotrunkfrom Sep 9, 2022
Merged
automatically set the height of the tabs across the languages#1157titusfortner merged 1 commit intotrunkfrom
titusfortner merged 1 commit intotrunkfrom
Conversation
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
Author
|
hmm, this doesn't work if a language isn't already set, so needs more tweaking. |
titusfortner
force-pushed
the
auto_height
branch
from
6515979 to
4e7765c
Compare
Member
Author
|
Ok, fixed the issue. Feedback appreciated. |
titusfortner
force-pushed
the
auto_height
branch
from
4e7765c to
73e09e0
Compare
titusfortner
added a commit
that referenced
this pull request
Sep 15, 2022
…nguages - #1157) [deploy site]
Member
Author
|
This had to get reverted because it doesn't consistently work for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing this manually before with "height" values. This is my attempt to do it automatically. @harsha1502 let me know if there's better JS for this. I'm not sure why docsy was doing
$('#' + element.id).tab('show')and why I could only get it to work withclick().If this looks good, I'll PR it to Docsy as well and see what they think.