Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionality: 5
Documentation: 5
Style: 4.5
Total: 4.8/5
This looks great! The MVC separation is clean -- each of your classes/functions does one thing, and it's easy to tell how they fit together.
A couple overarching comments...
swim_little_fish_swim.pyis a little heavy -- I think a lot of the code there could be abstracted away into the model, leaving you with a cleaner and more maintainable implementation.Look through the files changed to see more comments about specifics in your code. Feel free to respond to the comments inline -- more than happy to have a conversation.
Once you've read the comments, make a comment to the pull request letting us know that you've checked them out. Afterwards, close the PR.