Correct the documents when about fire exception#14
Open
wahyd4 wants to merge 1 commit intoSelvatico:masterfrom
Open
Correct the documents when about fire exception#14wahyd4 wants to merge 1 commit intoSelvatico:masterfrom
wahyd4 wants to merge 1 commit intoSelvatico:masterfrom
Conversation
When we'd like to fire exception when execute `INSERT` commands, we should call `.WithExecException()` rather than `.WithQueryException()`
Owner
|
@wahyd4 can you look into failing test, please? |
vallieres
approved these changes
Nov 30, 2018
Collaborator
vallieres
left a comment
vallieres
left a comment
There was a problem hiding this comment.
D'oh! Thanks for finding this out!
Author
|
Hi, @Selvatico I don't think the test failure is related to my change, I didn't change any source code or test code at all. Also, There is no error when I run the tests in my local many times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we'd like to fire exception when execute
INSERTcommands, we should call.WithExecException()rather than.WithQueryException()