[Icon] Fixed background issue when Icon is used as Labeled Icon for Button as loading one#7023
Merged
jlukic merged 1 commit intoSemantic-Org:nextfrom Oct 6, 2022
Merged
[Icon] Fixed background issue when Icon is used as Labeled Icon for Button as loading one#7023jlukic merged 1 commit intoSemantic-Org:nextfrom
jlukic merged 1 commit intoSemantic-Org:nextfrom
Conversation
flppv
changed the title
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
@lubber-de does it mean that this fix shouldn't be done here in Semantic UI? |
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
Frankly, I haven't heard about Fomantic earlier, as I am satisfied with Semantic UI. If there is an existing PR to fix that bug here, in SemanticUI, let me know and I'll close my one. |
This comment was marked as spam.
This comment was marked as spam.
jlukic
added a commit
that referenced
this pull request
Oct 6, 2022
Member
|
This PR breaks regular regular usage of I've implemented this in 49b9cbf and updated the docs to include an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See my initial issue Semantic-Org/Semantic-UI-React#4088
I moved
icon-loadinganimation into:beforeelement itself.Testcase
Before: https://jsfiddle.net/afkm1v7w/
After: https://jsfiddle.net/t16y3wLk/
(I demonstrated my changes in temporary CSS override)