Skip to content

Revert "[AMD] Upgrade GLM-5 SGLang mi35x image to 0.5.10 (#1014)"#1015

Merged
cquil11 merged 1 commit intomainfrom
revert-pr-1014
Apr 8, 2026
Merged

Revert "[AMD] Upgrade GLM-5 SGLang mi35x image to 0.5.10 (#1014)"#1015
cquil11 merged 1 commit intomainfrom
revert-pr-1014

Conversation

@cquil11
Copy link
Copy Markdown
Collaborator

@cquil11 cquil11 commented Apr 8, 2026

Summary

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

@cquil11 cquil11 merged commit 888ac6b into main Apr 8, 2026
8 checks passed
@cquil11 cquil11 deleted the revert-pr-1014 branch April 8, 2026 19:02
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward revert of a container image bump back to the previously working image.

Extended reasoning...

Overview

This PR reverts #1014, which upgraded the glm5-fp8-mi355x-sglang container image from rocm/sgl-dev:v0.5.8.post1-rocm720-mi35x-20260219 to lmsysorg/sglang:v0.5.10-rocm720-mi35x. The revert restores the prior image tag and removes the corresponding perf-changelog.yaml entry. Only two config/changelog files are touched.

Security risks

None. This is a config-only change swapping a Docker image tag; no code logic, auth, or data handling is modified.

Level of scrutiny

Low. Reverts are among the simplest and safest changes in a repo — they restore a known-good state. The diff is minimal and the intent is unambiguous.

Other factors

No bugs were found by the automated system. The only comment in the timeline is a boilerplate recipe-reminder from a bot, which is not applicable to a revert. The prior changelog entry being removed exactly matches what was added in #1014, confirming correctness.

@cquil11 cquil11 added the AMD label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

1 participant