Skip to content

[WIP] [AMD/ROCM] atom minimaxm2.5 fp4 on mi355x#1042

Merged
cquil11 merged 8 commits intomainfrom
srok/atom_minimaxm2.5_fp4
Apr 29, 2026
Merged

[WIP] [AMD/ROCM] atom minimaxm2.5 fp4 on mi355x#1042
cquil11 merged 8 commits intomainfrom
srok/atom_minimaxm2.5_fp4

Conversation

@seungrokj
Copy link
Copy Markdown
Collaborator

@seungrokj seungrokj commented Apr 16, 2026

hi,

WIP.
internally tested. shipping soon.

cc. @ChangLiu0709 @andyluo7 @chunfangamd @ajith-sirra-amd

Regards,
Seungrok

Signed-off-by: seungrokj <seungrok.jung@amd.com>
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

Comment thread .github/configs/amd-master.yaml Outdated
@seungrokj seungrokj added the AMD label Apr 16, 2026
Copy link
Copy Markdown
Contributor

@functionstackx functionstackx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz submit vllm minimax fp4 first. as an reminder. atom can be submit as additional framework after u submit vllm first for inferencev3

@benenzhu
Copy link
Copy Markdown
Collaborator

plz submit vllm minimax fp4 first. as an reminder. atom can be submit as additional framework after u submit vllm first for inferencev3

@functionstackx Hi for vllm minimax fp4, #827 can be merged using the nightly vllm image of vllm/vllm-openai-rocm:nightly-c48b2b83bd160cd684c8a2357f229e90de99298d, I have checked the accuracy and benchmark all passed.

@seungrokj
Copy link
Copy Markdown
Collaborator Author

plz submit vllm minimax fp4 first. as an reminder. atom can be submit as additional framework after u submit vllm first for inferencev3

@functionstackx Hi for vllm minimax fp4, #827 can be merged using the nightly vllm image of vllm/vllm-openai-rocm:nightly-c48b2b83bd160cd684c8a2357f229e90de99298d, I have checked the accuracy and benchmark all passed.

hi @benenzhu once
v0.19.1 img (https://hub.docker.com/r/vllm/vllm-openai-rocm/tag) is available, can you create vllm+minimaxm2.5+fp4 PR ?
#827 (comment)

@benenzhu
Copy link
Copy Markdown
Collaborator

plz submit vllm minimax fp4 first. as an reminder. atom can be submit as additional framework after u submit vllm first for inferencev3

@functionstackx Hi for vllm minimax fp4, #827 can be merged using the nightly vllm image of vllm/vllm-openai-rocm:nightly-c48b2b83bd160cd684c8a2357f229e90de99298d, I have checked the accuracy and benchmark all passed.

hi @benenzhu once v0.19.1 img (https://hub.docker.com/r/vllm/vllm-openai-rocm/tag) is available, can you create vllm+minimaxm2.5+fp4 PR ? #827 (comment)

@seungrokj Yeah I will update it to the release img.

@functionstackx
Copy link
Copy Markdown
Contributor

plz submit vllm minimax fp4 first. as an reminder. atom can be submit as additional framework after u submit vllm first for inferencev3

@functionstackx Hi for vllm minimax fp4, #827 can be merged using the nightly vllm image of vllm/vllm-openai-rocm:nightly-c48b2b83bd160cd684c8a2357f229e90de99298d, I have checked the accuracy and benchmark all passed.

Do u have link to full sweep pr validation pass + link to vllm recipe PR (if it needs any updating)

seungrokj and others added 3 commits April 25, 2026 14:10
seungrokj and others added 2 commits April 29, 2026 09:44
…OM/vLLM, and B300 MTP configs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@seungrokj
Copy link
Copy Markdown
Collaborator Author

@seungrokj
Copy link
Copy Markdown
Collaborator Author

@functionstackx @cquil11 can you approve this PR ?

@cquil11 cquil11 merged commit 3cfb0b9 into main Apr 29, 2026
18 checks passed
@cquil11 cquil11 deleted the srok/atom_minimaxm2.5_fp4 branch April 29, 2026 15:01
@cquil11 cquil11 restored the srok/atom_minimaxm2.5_fp4 branch April 30, 2026 20:17
cquil11 added a commit that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

4 participants