-
Notifications
You must be signed in to change notification settings - Fork 156
Add B200 config: qwen3.5-fp4-sglang-mtp #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| source "$(dirname "$0")/../benchmark_lib.sh" | ||
|
|
||
| check_env_vars \ | ||
| MODEL \ | ||
| TP \ | ||
| CONC \ | ||
| ISL \ | ||
| OSL \ | ||
| RANDOM_RANGE_RATIO \ | ||
| RESULT_FILENAME \ | ||
| EP_SIZE | ||
|
|
||
| if [[ -n "$SLURM_JOB_ID" ]]; then | ||
| echo "JOB $SLURM_JOB_ID running on $SLURMD_NODENAME" | ||
| fi | ||
|
|
||
| nvidia-smi | ||
|
|
||
| hf download "$MODEL" | ||
|
|
||
| export NCCL_NVLS_ENABLE=1 | ||
| export SGL_ENABLE_JIT_DEEPGEMM=false | ||
| export SGLANG_ENABLE_FLASHINFER_GEMM=true | ||
| export PYTHONUNBUFFERED=1 | ||
|
|
||
| SERVER_LOG=/workspace/server.log | ||
| PORT=${PORT:-8888} | ||
|
|
||
| # Default: recv every ~10 requests; if CONC >= 16, relax to ~30 requests between scheduler recv polls. | ||
| if [[ $CONC -ge 16 ]]; then | ||
| SCHEDULER_RECV_INTERVAL=30 | ||
| else | ||
| SCHEDULER_RECV_INTERVAL=10 | ||
| fi | ||
|
|
||
| MEM_FRAC_STATIC=0.85 | ||
| CHUNKED_PREFILL_SIZE=32768 | ||
| MAX_PREFILL_TOKENS=32768 | ||
| CUDA_GRAPH_MAX_BATCH_SIZE=$CONC | ||
| MAX_RUNNING_REQUESTS=128 | ||
| CONTEXT_LENGTH=$((ISL + OSL + 20)) | ||
| if [ "${EVAL_ONLY}" = "true" ]; then | ||
| setup_eval_context | ||
| CONTEXT_LENGTH="$EVAL_MAX_MODEL_LEN" | ||
| fi | ||
|
|
||
| if [[ $TP -eq 8 ]]; then | ||
| EXTRA_ARGS="--enable-flashinfer-allreduce-fusion" | ||
| else | ||
| EXTRA_ARGS="" | ||
| fi | ||
|
|
||
| echo "SCHEDULER_RECV_INTERVAL: $SCHEDULER_RECV_INTERVAL, CONC: $CONC, ISL: $ISL, OSL: $OSL" | ||
|
|
||
| # Start GPU monitoring (power, temperature, clocks every second) | ||
| start_gpu_monitor | ||
|
|
||
| set -x | ||
| PYTHONNOUSERSITE=1 python3 -m sglang.launch_server --model-path=$MODEL --host=0.0.0.0 --port=$PORT \ | ||
| --trust-remote-code \ | ||
| --tensor-parallel-size=$TP --data-parallel-size=1 --ep-size $EP_SIZE \ | ||
| --quantization modelopt_fp4 --fp4-gemm-backend flashinfer_cutlass \ | ||
| --kv-cache-dtype fp8_e4m3 \ | ||
| --mamba-ssm-dtype bfloat16 \ | ||
| --cuda-graph-max-bs $CUDA_GRAPH_MAX_BATCH_SIZE --max-running-requests $MAX_RUNNING_REQUESTS \ | ||
| --mem-fraction-static $MEM_FRAC_STATIC --chunked-prefill-size $CHUNKED_PREFILL_SIZE --max-prefill-tokens $MAX_PREFILL_TOKENS \ | ||
| --context-length $CONTEXT_LENGTH --disable-radix-cache \ | ||
| --attention-backend trtllm_mha --moe-runner-backend flashinfer_trtllm \ | ||
| $EXTRA_ARGS --scheduler-recv-interval $SCHEDULER_RECV_INTERVAL \ | ||
| --tokenizer-worker-num 6 --stream-interval 30 \ | ||
| --speculative-algorithm EAGLE \ | ||
| --speculative-num-steps 3 \ | ||
| --speculative-eagle-topk 1 \ | ||
| --speculative-num-draft-tokens 4 \ | ||
| > $SERVER_LOG 2>&1 & | ||
|
|
||
| SERVER_PID=$! | ||
|
|
||
| # Wait for server to be ready | ||
| wait_for_server_ready --port "$PORT" --server-log "$SERVER_LOG" --server-pid "$SERVER_PID" | ||
|
|
||
| pip install -q datasets pandas | ||
|
|
||
| run_benchmark_serving \ | ||
| --model "$MODEL" \ | ||
| --port "$PORT" \ | ||
| --backend vllm \ | ||
| --input-len "$ISL" \ | ||
| --output-len "$OSL" \ | ||
| --random-range-ratio "$RANDOM_RANGE_RATIO" \ | ||
| --num-prompts "$((CONC * 10))" \ | ||
| --max-concurrency "$CONC" \ | ||
| --result-filename "$RESULT_FILENAME" \ | ||
| --result-dir /workspace/ \ | ||
| --use-chat-template | ||
|
|
||
| # After throughput, run evaluation only if RUN_EVAL is true | ||
| if [ "${RUN_EVAL}" = "true" ]; then | ||
| run_eval --framework lm-eval --port "$PORT" | ||
| append_lm_eval_summary | ||
| fi | ||
|
|
||
| # Stop GPU monitoring | ||
| stop_gpu_monitor | ||
| set +x | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The new
qwen3.5_fp4_b200_mtp.shscript is missingSGLANG_ENABLE_SPEC_V2=1in its server launch command, which is present in most comparable MTP scripts (qwen3.5_fp8_h200_mtp.sh,qwen3.5_fp8_b300_mtp.sh,dsr1_fp8_b200_mtp.sh,dsr1_fp8_b300_mtp.sh). Without this env var, SGLang may fall back to the older Spec V1 speculative decoding code path, producing non-representative MTP benchmark numbers. AddSGLANG_ENABLE_SPEC_V2=1before thePYTHONNOUSERSITE=1 python3 -m sglang.launch_serverinvocation to match the established pattern.Extended reasoning...
What the bug is and how it manifests
The server launch command in
benchmarks/single_node/qwen3.5_fp4_b200_mtp.sh(lines 56–75) starts withPYTHONNOUSERSITE=1 python3 -m sglang.launch_server ...but is missing theSGLANG_ENABLE_SPEC_V2=1environment variable prefix. SGLang's speculative decoding has two implementations: the newer, optimized Spec V2 path and the older Spec V1 path. Without the env var, SGLang defaults to Spec V1, producing suboptimal MTP throughput numbers.The specific code path that triggers it
Lines 56–75 of the new script launch the SGLang server with EAGLE flags (
--speculative-algorithm EAGLE --speculative-num-steps 3 --speculative-eagle-topk 1 --speculative-num-draft-tokens 4) but omitSGLANG_ENABLE_SPEC_V2=1. Compare withqwen3.5_fp8_h200_mtp.shline 38 andqwen3.5_fp8_b300_mtp.shline 34, both of which prependSGLANG_ENABLE_SPEC_V2=1to identical launch patterns.Why existing code doesn't prevent it
The script was created by copying the non-MTP base script
qwen3.5_fp4_b200.shand adding EAGLE flags — but the non-MTP base has no need forSGLANG_ENABLE_SPEC_V2=1, so the env var was never present to copy over. There is no linting or template enforcement to catch this class of omission.Addressing the refutation
One verifier noted that
qwen3.5_fp8_b200_mtp.shalso lacksSGLANG_ENABLE_SPEC_V2=1, suggesting this may be an intentional pattern for same-hardware (B200) scripts or that newer nightly images default to Spec V2. This is a fair observation. However: (1) there is no documented evidence that the nightly-dev-20260402 image enables Spec V2 by default; (2) PR #1017 was explicitly created to retroactively add this var toqwen3.5_fp8_h200_mtp.shafter it was missed, establishing that its omission produces non-representative results and must be corrected; (3) four of the six single-node MTP SGLang scripts include it. The safer and more consistent choice is to explicitly set the env var.Step-by-step proof
qwen3.5-fp4-b200-sglang-mtpconfig (spec-decoding: mtp → selectsqwen3.5_fp4_b200_mtp.sh).PYTHONNOUSERSITE=1 python3 -m sglang.launch_server ... --speculative-algorithm EAGLE ...SGLANG_ENABLE_SPEC_V2is unset, SGLang initializes the legacy Spec V1 speculative decoding engine.How to fix it
Prefix the launch command with
SGLANG_ENABLE_SPEC_V2=1, matching the pattern inqwen3.5_fp8_b300_mtp.shline 34: