Skip to content

DSV4 B300 DPA rerun #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oseltamivir wants to merge 2 commits into from
Closed

DSV4 B300 DPA rerun #1162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f419f7
DSV4 B300 DPA rerun
Oseltamivir Apr 26, 2026
ba59a26
Update perf-changelog.yaml
Oseltamivir Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1833,3 +1833,9 @@
- "Bump --chunked-prefill-size from 4096 to 8192"
- "Retrigger dsv4-fp8-mi355x-sglang"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1160

- config-keys:
- dsv4-fp4-b300-sglang
description:
- "Retrigger DSV4 B300 DPA runs"
Comment on lines +1837 to +1840
Copy link
Copy Markdown
Contributor

@claude claude Bot Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The new changelog entry at lines 1837-1840 is missing the required pr-link field. The ChangelogEntry Pydantic model in utils/matrix_logic/validation.py declares pr_link with no default and extra="forbid", so loading this file will raise a ValidationError. Add pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1162 to match every other entry in the file (including the recent retrigger entries #1148, #1159, and #1160).

Extended reasoning...

What the bug is

The new changelog entry added by this PR (perf-changelog.yaml:1837-1840) is:

- config-keys:
    - dsv4-fp4-b300-sglang
  description:
    - "Retrigger DSV4 B300 DPA runs"

It has no pr-link field. Every one of the 207 other entries in the file has a pr-link (this PR's entry is the only one missing it).

Why this breaks validation

utils/matrix_logic/validation.py declares the schema for entries in this file:

class ChangelogEntry(BaseModel):
    model_config = ConfigDict(extra="forbid", populate_by_name=True)
    ...
    pr_link: str = Field(alias="pr-link")

pr_link has no default value, so it is a required field. With extra="forbid" the model also rejects unknown keys, but the failure here is the missing required key: when the changelog loader (load_config_files / process_changelog) constructs a ChangelogEntry from this dict it will raise a Pydantic ValidationError with "Field required: pr-link".

Why retriggers don't get a pass

The recent retrigger entries demonstrate the convention: PR #1148 (line ~1819), PR #1159 (the previous dsv4-fp4-b300-sglang retrigger), and PR #1160 (line 1835, immediately above the new entry) all include pr-link. So a "retriggers don't need pr-link" exception does not exist — this is just an oversight.

Step-by-step proof

  1. Load perf-changelog.yaml with PyYAML — produces a list of dicts; the last dict has keys config-keys and description only.
  2. The loader iterates and constructs ChangelogEntry(**entry) (with alias resolution).
  3. Pydantic validates: pr_link is required (no default), but the dict has no pr-link key.
  4. ValidationError is raised, aborting changelog processing for this PR.

Fix

Append pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1162 after the description block, matching the format of every adjacent entry.

Impact

Severity is "normal" — anything in CI that calls process_changelog against this file (the changelog-driven tooling that decides which configs ran in which PR) will fail until the field is added. The fix is a single line.

pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1161
Loading