dsv4-b300-sglang: retry#1178
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
There was a problem hiding this comment.
LGTM, straightforward perf-changelog entry.
Extended reasoning...
Overview
This PR appends a single 7-line entry to perf-changelog.yaml documenting improved dp-attention performance for the dsv4-fp4-b300-sglang config, with a link to PR #1178 and the SGLang cookbook recipe source. It follows the exact same pattern as the ~100 prior entries in the file.
Security risks
None. This is a documentation/changelog YAML file with no executable code, no credentials, and no impact on runtime behavior.
Level of scrutiny
Minimal. This is a mechanical changelog append that mirrors many similar entries already in the file. The corresponding implementation work appears to already be merged (commit fc1716e on main with the same title), so this entry is just the documentation companion.
Other factors
No bugs were flagged by the bug hunting system. The YAML structure matches the surrounding entries exactly (config-keys list, description list, pr-link). No reviewer comments are outstanding — only the standard recipe-reminder bot comment.
* dsv4-fp4-b300-sglang: revert to #1143 low-latency-only baseline Reverts the matrix expansion (#1132), script edits (#1158, #1173, #1174), and changelog retriggers (#1178) on top of the original #1143 entry. Restores the script and config block to their #1143 state and clears all prior dsv4-fp4-b300-sglang changelog entries to start fresh. The dsv4-fp4-b300-sglang-mtp config (#1166) is untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * perf-changelog: add pr-link for #1184 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * perf-changelog: keep only the original #1143 entry, drop new entry Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Test plan
🤖 Generated with Claude Code