-
Notifications
You must be signed in to change notification settings - Fork 156
[NVIDIA] feat: adds more configurations for GB200 SGLang DSR1 #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a1a0325
bring all configs here
Elnifio c03076b
test for GB200 only
Elnifio 028f224
updates the files and git clone urls
Elnifio 25a19b1
update the prefill nodes
Elnifio 124ddf4
update 1k1k fp4 config
Elnifio 6199031
updates to run 1k1k fp4 only
Elnifio 344ac6c
updates the FP4 8k1k
Elnifio 355773a
update the model path
Elnifio 0dd1e5a
restore changes to full sweeps
Elnifio 7da0be5
updates the config for 1k1k fp4
Elnifio b38b633
temporarily disable some concurrencies
Elnifio 8136816
updates the params
Elnifio c1f1be4
updates the branch
Elnifio 7a8e890
update config
Elnifio ce40018
temporarily disable all other configs
Elnifio 35c7eb3
Revert "temporarily disable all other configs"
Elnifio b26d699
update comments
Elnifio 5b0509a
Merge branch 'main' into ishan/moreconfigs
cquil11 c1024db
bump the image for DSR1
Elnifio 3d4c3ae
Merge branch 'main' into ishan/moreconfigs
yunzhoul-nv 35d7555
update the model-path args
Elnifio 45cc883
model-path not permitted
Elnifio a6cc157
switches the branch
Elnifio 2731ccb
Merge branch 'main' into ishan/moreconfigs
cquil11 b3ccea8
add perf changelog
cquil11 00dcff7
used the wrong model path here...
Elnifio e845bdd
Merge branch 'main' into ishan/moreconfigs
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
|
|
||
| #!/bin/bash | ||
|
|
||
| set -x | ||
|
|
||
| source "$(dirname "$0")/benchmark_lib.sh" | ||
|
|
||
| check_env_vars CONC_LIST ISL OSL IMAGE SPEC_DECODING MODEL_PATH \ | ||
| PREFILL_NUM_WORKERS PREFILL_TP PREFILL_EP PREFILL_DP_ATTN \ | ||
| DECODE_NUM_WORKERS DECODE_TP DECODE_EP DECODE_DP_ATTN \ | ||
| PREFILL_NODES DECODE_NODES N_ADDITIONAL_FRONTENDS SGL_SLURM_JOBS_PATH # SGL_SLURM_JOBS_PATH FIXME | ||
|
|
||
| # Always clone and setup Dynamo | ||
| echo "Cloning Dynamo repository..." | ||
| git clone https://github.com/ai-dynamo/dynamo.git | ||
| cd dynamo && git checkout b7107d008392eded64c23a7540fb99bca46b4c91 && cd .. # All configs are frozen in this branch | ||
|
|
||
| cd "$SGL_SLURM_JOBS_PATH" | ||
|
|
||
| # Set up SGL launch script-specific environment variables | ||
| export TIME_LIMIT="04:00:00" | ||
| export MODEL_PATH=$MODEL_PATH | ||
| export CONFIG_DIR=$CONFIG_DIR | ||
| export CONTAINER_IMAGE=$IMAGE | ||
| export GPU_TYPE="gb200-fp4" | ||
|
|
||
| # Launch jobs based on ISL/OSL | ||
| # Replace ' ' in CONC_LIST with 'x' such that the concurrency list is represented | ||
| # by a list of numbers delimted by 'x'. This is because of how the underlying launch script | ||
| # expects the concurrencies. | ||
| bash ./submit_disagg.sh $PREFILL_NODES \ | ||
| $PREFILL_NUM_WORKERS \ | ||
| $DECODE_NODES \ | ||
| $DECODE_NUM_WORKERS \ | ||
| $N_ADDITIONAL_FRONTENDS \ | ||
| $ISL $OSL "${CONC_LIST// /x}" inf \ | ||
| $GPU_TYPE \ | ||
| $SCRIPT_MODE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks