[AMD] Update MI355x Deepseek-R1 FP4 SGLang Image to v0.5.6.post2#369
[AMD] Update MI355x Deepseek-R1 FP4 SGLang Image to v0.5.6.post2#369
Conversation
ppalanga
changed the title
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR updates the SGLang Docker image for the MI355x DeepSeek-R1 FP4 configuration from v0.5.6.post1 to v0.5.6.post2, aligning with the upstream SGLang community image.
- Updates SGLang image version to v0.5.6.post2-rocm700-mi35x
- Adds corresponding changelog entry for tracking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/configs/amd-master.yaml |
Updates the SGLang Docker image version from v0.5.6.post1 to v0.5.6.post2 for the dsr1-fp4-mi355x-sglang configuration |
perf-changelog.yaml |
Adds changelog entry documenting the image update to v0.5.6.post2 with reference to PR #369 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the SGLang Docker image for the dsr1-fp4-mi355x-sglang configuration to v0.5.6.post2. The change is correctly applied to the amd-master.yaml configuration file, and a corresponding entry has been added to perf-changelog.yaml to document this update. The changes are straightforward and align with the PR's intent. I have one minor suggestion to improve the consistency of the changelog entry.
| - config-keys: | ||
| - dsr1-fp4-mi355x-sglang | ||
| description: | ||
| - "Updating MI355x Deepseek-R1 FP4 SGLang Image to upstream v0.5.6.post2" |
There was a problem hiding this comment.
For consistency with other entries in this changelog, it's better to use the imperative mood for the description. Most other entries start with a verb like "Update", "Add", or "Fix", whereas this one uses "Updating".
- "Update MI355x Deepseek-R1 FP4 SGLang Image to upstream v0.5.6.post2"
|
@cquil11 does this PR look good to u? seems like it passed validation and ready to merge? |
github-project-automation
Bot
moved this from In Progress
to Done
in InferenceMAX Board
cquil11
changed the title
Updating the SGLang docker image to the SGLang community docker image
Image=
lmsysorg/sglang:v0.5.6.post2-rocm700-mi35xImpacted configurations: MI355x Deepseek-R1 FP4
Link to the runs:
https://github.com/InferenceMAX/InferenceMAX/actions/runs/20436306629/