Skip to content

[AMD] Update MI355x Deepseek-R1 FP4 SGLang Image to v0.5.7#395

Merged
chunfangamd merged 2 commits intomainfrom
ppalanga/update_sglang_image_to_0.5.7
Jan 12, 2026
Merged

[AMD] Update MI355x Deepseek-R1 FP4 SGLang Image to v0.5.7#395
chunfangamd merged 2 commits intomainfrom
ppalanga/update_sglang_image_to_0.5.7

Conversation

@ppalanga
Copy link
Copy Markdown
Collaborator

@ppalanga ppalanga commented Jan 7, 2026

Updating the SGLang docker image to the SGLang community docker image
Image=lmsysorg/sglang:v0.5.7-rocm700-mi35x

Impacted configurations: MI355x Deepseek-R1 FP4

Link to the runs: TBD


Note

Updates MI355x DeepSeek-R1 FP4 SGLang config to use the upstream v0.5.7 image and records the change.

  • Bump image for dsr1-fp4-mi355x-sglang to lmsysorg/sglang:v0.5.7-rocm700-mi35x in .github/configs/amd-master.yaml
  • Add entry in perf-changelog.yaml documenting this update

Written by Cursor Bugbot for commit 9dc7f1a. This will update automatically on new commits. Configure here.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ppalanga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the SGLang Docker image to version v0.5.7 for the MI355x Deepseek-R1 FP4 configuration. This change ensures that the specified configuration utilizes the latest SGLang community image, potentially incorporating recent features, performance enhancements, or bug fixes from the SGLang project.

Highlights

  • SGLang Image Update: The SGLang Docker image for the dsr1-fp4-mi355x-sglang configuration has been updated from v0.5.6.post2 to v0.5.7.
  • Configuration File Change: The .github/configs/amd-master.yaml file was modified to reflect the new SGLang image version.
  • Changelog Entry: A new entry has been added to perf-changelog.yaml documenting the update of the MI355x Deepseek-R1 FP4 SGLang Image to upstream v0.5.7.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SGLang docker image for the dsr1-fp4-mi355x-sglang configuration to version v0.5.7. The change is correctly applied to .github/configs/amd-master.yaml and documented in perf-changelog.yaml. My review identifies a minor issue in the changelog file where a placeholder for the pull request link needs to be updated.

Comment thread perf-changelog.yaml Outdated
@ppalanga ppalanga marked this pull request as ready for review January 7, 2026 17:55
@ppalanga ppalanga requested a review from a team as a code owner January 7, 2026 17:55
@ppalanga ppalanga enabled auto-merge (squash) January 7, 2026 17:55
@ppalanga ppalanga requested a review from chunfangamd January 7, 2026 17:55
@functionstackx
Copy link
Copy Markdown
Contributor

@ppalanga any reason why this pr is only mi355 fp4 and not mi300/mi325/mi355 fp8? or should we expect that in follow up PR

@ppalanga
Copy link
Copy Markdown
Collaborator Author

ppalanga commented Jan 7, 2026

@ppalanga any reason why this pr is only mi355 fp4 and not mi300/mi325/mi355 fp8? or should we expect that in follow up PR

Yes, the FP8 will be available in a different PR. Thanks!

@cquil11 cquil11 moved this to In Progress in InferenceMAX Board Jan 12, 2026
Copy link
Copy Markdown
Collaborator

@cquil11 cquil11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once sweep passes

@cquil11 cquil11 force-pushed the ppalanga/update_sglang_image_to_0.5.7 branch from 7b94836 to e33f52d Compare January 12, 2026 02:10
auto-merge was automatically disabled January 12, 2026 02:10

Head branch was modified

@chunfangamd chunfangamd merged commit 2c679ab into main Jan 12, 2026
28 checks passed
@chunfangamd chunfangamd deleted the ppalanga/update_sglang_image_to_0.5.7 branch January 12, 2026 10:57
@github-project-automation github-project-automation Bot moved this from In Progress to Done in InferenceMAX Board Jan 12, 2026
@cquil11 cquil11 added the AMD label Apr 8, 2026
@cquil11 cquil11 changed the title Update MI355x Deepseek-R1 FP4 SGLang Image to v0.5.7 [AMD] Update MI355x Deepseek-R1 FP4 SGLang Image to v0.5.7 Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants