Skip to content

[NVIDIA] Update DSR1 FP4 SGLang Image from 0.5.7 to 0.5.8#595

Merged
functionstackx merged 5 commits intomainfrom
thomas_poovaiah_chun/dsr1_fp4_v058
Jan 29, 2026
Merged

[NVIDIA] Update DSR1 FP4 SGLang Image from 0.5.7 to 0.5.8#595
functionstackx merged 5 commits intomainfrom
thomas_poovaiah_chun/dsr1_fp4_v058

Conversation

@ppalanga
Copy link
Copy Markdown
Collaborator

Updating the SGLang docker image to the SGLang community docker image
Image=lmsysorg/sglang:v0.5.8-rocm700-mi35x

Impacted configurations: MI355x Deepseek-R1 FP4

Link to the runs: TBD

@ppalanga ppalanga requested a review from chunfangamd January 28, 2026 21:03
@ppalanga ppalanga marked this pull request as ready for review January 28, 2026 23:23
@ppalanga ppalanga requested a review from a team as a code owner January 28, 2026 23:23
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jan 28, 2026

Claude finished @ppalanga's task in 42s —— View job


PR Review Complete

  • Gather context and read changed files
  • Validate master config and perf-changelog requirements
  • Validate container image accessibility
  • Review code changes for bugs and issues
  • Post review summary

LGTM - no blocking issues found

This PR updates the SGLang Docker image for dsr1-fp4-mi355x-sglang from v0.5.7 to v0.5.8. The changes are straightforward and all requirements are met:

  • perf-changelog.yaml has been updated with the config change
  • ✅ Docker image lmsysorg/sglang:v0.5.8-rocm700-mi35x is publicly accessible on Docker Hub
  • ✅ No bugs or breaking changes detected

Copy link
Copy Markdown
Contributor

@functionstackx functionstackx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to pass all the validation!

thanks for the PR!

Image

Comment thread perf-changelog.yaml Outdated
- config-keys:
- dsr1-fp4-mi355x-sglang
description:
- "Update SGL image to 0.5.8"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude make this description more descrptive for example what sglang version did it update from and that this effects deepseek r1 fp4 sglang

Copy link
Copy Markdown
Collaborator

@Klaud-Cold Klaud-Cold Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude finished @functionstackx's task in 37s —— View job


Updating perf-changelog.yaml description

  • Understand the request
  • Read the current perf-changelog.yaml entry
  • Update the description to be more descriptive
  • Commit and push the changes

Done! Updated the perf-changelog.yaml description from:

"Update SGL image to 0.5.8"

to:

"Update SGLang image from v0.5.7 to v0.5.8 for DeepSeek-R1 FP4 on MI355x"

Updated description to be more descriptive: specifies the version update
from v0.5.7 to v0.5.8 and clarifies this affects DeepSeek-R1 FP4 on MI355x.

Co-authored-by: functionstackx <functionstackx@users.noreply.github.com>
@functionstackx functionstackx merged commit 7f4d57f into main Jan 29, 2026
12 checks passed
@functionstackx functionstackx deleted the thomas_poovaiah_chun/dsr1_fp4_v058 branch January 29, 2026 03:24
@cquil11 cquil11 added the NVIDIA label Apr 8, 2026
@cquil11 cquil11 changed the title Update DSR1 FP4 SGLang Image from 0.5.7 to 0.5.8 [NVIDIA] Update DSR1 FP4 SGLang Image from 0.5.7 to 0.5.8 Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

5 participants