A possible way to deal with elisions#26
Open
odelmarcelle wants to merge 3 commits intoSentometricsResearch:masterfrom
Open
A possible way to deal with elisions#26odelmarcelle wants to merge 3 commits intoSentometricsResearch:masterfrom
odelmarcelle wants to merge 3 commits intoSentometricsResearch:masterfrom
Conversation
Collaborator
|
Nice addition, well documented & good unit test! Some feedback:
Once the changes are pushed, we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current tokenization leaves French elisions attached to their words. This causes some sentiment words to not be identified when computing sentiment. For example, "l'abandon" is not identified as negative whereas "abandon" is a negative word in the French LoughranMcDonald lexicon.
This pull request adds an argument to
compute_sentiment, defaulting toTRUE, that simply removes a number of elision patterns at the beginning of each word. I'm not certain how this can affect other languages, but I don't see how to make a language-specific filter with the current implementation.See the test file for an example.