Replace all typeof(T).GUID uses with RVA fields#669
Merged
Sergio0694 merged 12 commits intomainfrom Nov 23, 2023
Merged
Conversation
Also adopt collection expressions for all IIDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #551, contributes to #598
Description
This PR removes all
typeof(T).GUIDuses across ComputeSharp, and replaces them with RVA fields.Sames ~300 KB in the self-contained native library sample, without reflection-free enabled.
These changes also make ComputeSharp.D2D1 work in reflection-free mode with NativeAOT 🚀
Note
Sizoscope only reports ~274 KB saved, but the actual binary is 304 KB smaller.