Skip to content

feat: Moving publish_jsr.yml to separate PR#9

Closed
Mqxx wants to merge 4 commits into
mainfrom
jsr-publish-extra-file
Closed

feat: Moving publish_jsr.yml to separate PR#9
Mqxx wants to merge 4 commits into
mainfrom
jsr-publish-extra-file

Conversation

@Mqxx
Copy link
Copy Markdown
Member

@Mqxx Mqxx commented Jan 22, 2026

No description provided.

@Mqxx Mqxx requested a review from Katze719 January 22, 2026 07:47
@Mqxx Mqxx self-assigned this Jan 22, 2026
@Mqxx Mqxx marked this pull request as draft January 22, 2026 07:51
@Mqxx Mqxx removed the request for review from Katze719 January 22, 2026 07:51
@Mqxx Mqxx changed the title feat: Moving publish_jsr.yml to separate file feat: Moving publish_jsr.yml to separate PR Jan 22, 2026
@Katze719
Copy link
Copy Markdown
Member

why? what does this PR add? that is not allready implemented? i hope you know that https://github.com/Serial-IO/cpp-bindings-linux/blob/main/.github/workflows/publish-jsr.yml exists

@Katze719
Copy link
Copy Markdown
Member

and having

on:
  workflow_run:
    workflows: ['Build Binary']
    types:
      - completed

with

if: github.event.workflow_run.event == 'push' && github.event.workflow_run.head_branch == 'main'

is simply terrible

@Katze719 Katze719 closed this Jan 22, 2026
@Mqxx Mqxx deleted the jsr-publish-extra-file branch January 22, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants