Conversation
tscholak
reviewed
Nov 23, 2025
Collaborator
tscholak
left a comment
There was a problem hiding this comment.
good progress, let's land GDN first please.
can you split this up into two PRs?
tscholak
reviewed
Dec 1, 2025
| ) | ||
|
|
||
|
|
||
| _update_and_add_testing_config( |
Collaborator
There was a problem hiding this comment.
can you keep both the apriel2 and the hybrid_gdn fixtures here please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Adding support for gated DeltaNet mixer. This tries to follow the reference code from, with some differences https://github.com/huggingface/transformers/blob/a5c903f877fda21e739027eed133e03162eb7712/src/transformers/models/qwen3_next/modeling_qwen3_next.py#L593
TODOs:
Note:
compare_factorhad to be raised to 10 to pass bf16 and fp16 tests, otherwise it fails in the normtp2should not be used with these modules (kda, gdn) because of norm inside of them🔍 Type of change
Select all that apply:
📝 Changes
✅ Checklist
Make sure the following tasks are completed before submitting the PR:
General
Dependencies and Configuration
Testing
Performance Impact
📊 Performance Impact Details
If there is any impact on performance, describe it and provide benchmark results, if applicable:
🗒️ Additional Notes
Include any additional context, information, or considerations here, such as known issues, follow-up tasks, or backward compatibility concerns.