Skip to content

Tiny fixes #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlamypoirier merged 3 commits into from
Dec 8, 2025
Merged

Tiny fixes #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2ed614
multimodal batch config
oleksost Dec 7, 2025
a545dee
lm head test fix
oleksost Dec 7, 2025
e6db7a0
clean
oleksost Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fast_llm/models/multimodal/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ class PretrainedMultiModalModelConfig(PretrainedGPTModelConfig):

@config_class(dynamic_type={RunnableConfig: "train_multimodal", TrainerConfig: "multimodal"})
class MultiModalTrainerConfig(PretrainedMultiModalModelConfig, GPTTrainerConfig):
batch: MultiModalBatchConfig = FieldUpdate()
# TODO: Use dynamic model type?
reference_models: dict[str, PretrainedMultiModalModelConfig] = FieldUpdate()

Expand Down
2 changes: 1 addition & 1 deletion tests/layers/test_lm_head.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _reverse_kl_loss(
loss_per_sample = torch.nn.functional.kl_div(
teacher_log_probs, student_log_probs, reduction="none", log_target=True
).sum(dim=-1)
loss = (loss_per_sample * loss_mask.flatten()).mean()
loss = (loss_per_sample * loss_mask.flatten()).sum() / loss_mask.sum()
return loss


Expand Down
Loading