Skip to content

added smooth scrolling, back to top button#18

Merged
deepak4566 merged 5 commits intoServiceToMankind:mainfrom
rajatrajputdev:feature/smooth-scroll
Oct 9, 2023
Merged

added smooth scrolling, back to top button#18
deepak4566 merged 5 commits intoServiceToMankind:mainfrom
rajatrajputdev:feature/smooth-scroll

Conversation

@rajatrajputdev
Copy link
Contributor

@rajatrajputdev rajatrajputdev commented Oct 7, 2023

I've added smooth scrolling, and added a button in which when user scrolls down a button on the bottom appears and if the user clicks on it, he gets back to the top of the website. Please also add hacktoberfest labels to it.

@KiranPranay
Copy link
Member

KiranPranay commented Oct 7, 2023

@rajatuiwebdev , Thanks for the contribution, but please add your css rules into style.scss and leave style.css untouched.
Refer CONTRIBUTION.md
Also, create "back to top" button from opencodelaw.js directly
for eg:

    // create back to top button
    backToTop.classList.add("back-to-top");
    backToTop.id = "backToTop";
    backToTop.title = "Go to top";
    backToTop.textContent = "↑";
    backToTop.addEventListener("click", () => {
      window.scrollTo({ top: 0, behavior: "smooth" });
    }
    );

Please, add all yours script directly to js/opencodelaw.js without creating any new files.

@rajatrajputdev
Copy link
Contributor Author

did the required commits, please check. and compile the sass before using the feature.

@KiranPranay
Copy link
Member

@rajatuiwebdev plz resolve conflicts in css/style.scss and js/opencodelaw.js .
Then good to go 👍🏼 .

@rajatrajputdev
Copy link
Contributor Author

@rajatuiwebdev plz resolve conflicts in css/style.scss and js/opencodelaw.js . Then good to go 👍🏼 .

resolved the issues.

@deepak4566 deepak4566 merged commit 622b577 into ServiceToMankind:main Oct 9, 2023
KiranPranay added a commit that referenced this pull request Oct 9, 2023
Signed-off-by: kiranpranay <pranaybannu12@gmail.com>
@KiranPranay
Copy link
Member

@rajatuiwebdev plz resolve conflicts in css/style.scss and js/opencodelaw.js . Then good to go 👍🏼 .

resolved the issues.

There are some conflicts, anyway i resolved it. Thank you 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants