Update imgui and fix missing backends in the cimgui.dll#5
Draft
jroweboy wants to merge 2 commits intoSewer56:masterfrom
Draft
Update imgui and fix missing backends in the cimgui.dll#5jroweboy wants to merge 2 commits intoSewer56:masterfrom
jroweboy wants to merge 2 commits intoSewer56:masterfrom
Conversation
Author
|
I'm moving this to a draft PR until i work out a few more issues. 32 bit builds with vulkan aren't working so I either need to drop that or fix it before this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also the related submodule prs for cimgui Sewer56/cimgui#1 and DearImGuiSharp-NativeBuild Sewer56/DearImGuiSharp-NativeBuilds#1
Changes
Updates Imgui bindings to the latest 1.89.3 and fixes issues with msvc builds for extra backends. In the current library, the bindings include the bindings for backends such as GLFW but they are actually not present in the dll. (This took me way too long to figure out :P)
Note
I didn't update the Linux or MacOS as 1) i don't have the build environments for them setup 2) they don't use these platform backends anyway
Screenshots
Below: DLL export listing for the current x86 cimgui.dll
After this PR, they are now present in the dll