(SPD): Fix potential crash when registering spds through the api#30
Merged
Sewer56 merged 1 commit intoSewer56:mainfrom Apr 21, 2025
Merged
(SPD): Fix potential crash when registering spds through the api#30Sewer56 merged 1 commit intoSewer56:mainfrom
Sewer56 merged 1 commit intoSewer56:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small fix to change the
_pathToStreamDictionary to a ConcurrenctDictionary to prevent an exception being thrown when registering a file through the API whilst something else is using the dictionary already.This now matches with PAK, BMD, and BF emulators which also use a ConcurrentDictionary for this.
I'd guess that this was never encountered before because TryAdd was being used (which I changed in #29), so possibly the registered files weren't actually being registered. Hopefully it is the only problem, everything else seems good so far.